search

archlinux / archinstall

Arch Linux installer - guided, templates etc.
GNU General Public License v3.0
5.95k stars 514 forks source link

Improve wording of formatting partitions before applying changes #2334

Open 42Willow opened 7 months ago

42Willow commented 7 months ago

Correct me if I'm wrong, as maybe I would've actually formatted my entire SSD :eyes:

I have an NVME SSD, I selected manual partitioning with archinstall and hit go. It then came up with a message saying formatting "/dev/nvme0n1 in 5, 4, 3," etc. As I didn't want to format my entire SSD (I am dual booting, and this is my main system) I cancelled. Could someone please tell me if it is safe to go ahead? If so, then there definitely should be a more verbose message - I only selected /dev/nvme0n1p5 and /dev/nvme0n1p6 to be formatted.

Two people in the discord support channel seemed to have had the same issue, but it wasn't resolved.

https://github.com/archlinux/archinstall/blob/f107104103b74ac065a56bd94a0878f0d263e177/archinstall/lib/disk/filesystem.py#L42

svartkanin commented 7 months ago

Without seeing the log file I can't say for sure what actually would have been formatted :shrug: The message that is displayed is a "be aware that will start applying your selected config now". It could be reworded to be more clear for sure.