Closed C0rn3j closed 2 months ago
I do understand the idea here, but I'm not sure if that is going to be confusing for people. I think generally people are more familiar with calling it KDE rather than Plasma.
Kubuntu uses both KDE and Pladma terms https://ubuntu.com/desktop/flavours
Fedora calls it KDE Plasma https://fedoraproject.org/spins/
Can we go the same route here and call it "KDE Plasma"
Kubuntu uses both KDE and Plasma terms https://ubuntu.com/desktop/flavours
They refer to KDE software in general as KDE, and the DE as Plasma, which is its short form.
Fedora calls it KDE Plasma https://fedoraproject.org/spins/
That's the long form
Can we go the same route here and call it "KDE Plasma"
Personally I prefer the short form so people stop using a name from 2007 and earlier, but both the "Plasma" the commit uses and "KDE Plasma" that you're suggesting is fine.
""description": "Specific profile to be installed based on the 'main' selection; these profiles are present in default_profiles/, use the file name of a profile without the extension to install it (case insensitive)","
Someone please verify that what I wrote here makes sense, I might have misunderstood how the script works. Is it using the file name, or actually what's defined in the file itself?
Also you will need to test if this is backwards compatible by loading an old configuration with this change
you will need to test if this is backwards compatible
It's not, it renames the profile, and the class.
People using the old wrong naming will need to target the new one.
Good thing Plasma 6 is just released, so the few people that have custom archinstall configs may not be so upset about having to do so.
For this to move forward I suggest to change the naming to "KDE Plasma" as it will align with other distributions naming convention. It's probably not the most accurate but less confusing. Also I don't think breaking backwards compability for such a minor update is not a good way to handle it and it doesn't take much to make it compatible.
as it will align with other distributions naming convention
Arch Linux wiki mostly uses the shorthand in writing.
Not even KDE uses the full name on the Plasma page.
Either the full name or the short form is fine, as it ceases being "KDE" when Plasma is meant to be referred to, if you believe it will be better, let's use that, I replaced the user-facing parts where it's used with "KDE Plasma", and kept internal code to "Plasma" for brevity.
Also I don't think breaking backwards compability for such a minor update is not a good way to handle it and it doesn't take much to make it compatible.
The profile name has to change, it currently is "Kde" which is wrong AND wrongly capitalized.
Having said that, we do not need to do so in a breaking fashion, I've attempted to keep both right now.
This would keep both names, deprecating the old one, and the old one would be removed in an archinstall release or two, giving people time to migrate.
@svartkanin I wanted to test it first but got a bit of internet issues, so it was taking a long time to download the premade ISO I wished to use…
I see you got there before me, thanks!
It looked good from the code but I'll run through it today, thanks for the change!
Seems to not be duped anymore at least, unsure if Kde
will actually work properly though.
PR Description:
Just like shorthand for
Microsoft Office
isOffice
, shorthand forKDE Plasma
isPlasma
.Rename files and code as such, capitalize existing code.
This also removes a dead misspelled profile from schema.json and fixes up the profile description there.
Tests and Checks