search

archlinux / archinstall

Arch Linux installer - guided, templates etc.
GNU General Public License v3.0
5.84k stars 508 forks source link

Adds dosfstools to the PKGBUILD depends #2439

Closed digital-raven closed 1 month ago

digital-raven commented 3 months ago

One of the tools needed by archinstall is mkfs.fatXX and this wasn't automatically installed.

PR Description:

This adds dosfstools, which provides the mkfs.fat binary which is used in device_handler.py

Tests and Checks

When I run makepkg -s on my system with or without this change, I receive an error that my build did not pass the "validity check". I don't know if this has bearing on the integrity of this change, so I left the following checklist for what I believe would be a good test of this change.

digital-raven commented 1 month ago

Hey guys, I'm still watching this! It's not a big deal for me personally as I was able to just install it and that's a decent workaround, but this is something that I think a newer user would be intimidated by were they to use archinstall on its own. I think it's a short and sweet improvement.

svartkanin commented 1 month ago

Are you saying that it's missing on the ISO or that it could be missing when running archinstall on another system?

digital-raven commented 1 month ago

It's missing when running archinstall on another system. If dosfstools is not already present, then pacman -S archinstall will not install it, and it's a necessary tool for archinstall's operation.

svartkanin commented 1 month ago

I think in that guess it's reasonable to include it in the configuration

Torxed commented 1 month ago

IT doesn't hurt to add it, if it's used to bootstrap a VM for instance from an existing system. But we've gotten lucky that the ISO releng has it shipped automatically.

svartkanin commented 1 month ago

I assumed it should as it's a requirement for it to work on the iso, but I didn't check to make sure. Thanks @Torxed for confirming