search

archlinux / archinstall

Arch Linux installer - guided, templates etc.
GNU General Public License v3.0
5.82k stars 509 forks source link

Fix 2496 - umounting all partitions #2498

Closed svartkanin closed 1 month ago

svartkanin commented 1 month ago

This fixes #2496

I was able to reproduce the problem on the latest master and with this change it seems to be fixed.

The problem is that during the partitioning/formatting the umount_all_existing is called multiple times, even after existing partitions have been deleted already which results in trying to umount these deleted partitions as a old reference object is used. There shouldn't be any need to call the umount each time a partitioning or formatting is performed but only once for each disk involved.

svartkanin commented 1 month ago

@Torxed could you approve this to get it in :)

Torxed commented 1 month ago

Good job! Approved and merged!

DeN-AlB commented 1 month ago

Nice guys! Thanks a lot!