archlinux / archinstall

Arch Linux installer - guided, templates etc.
GNU General Public License v3.0
5.82k stars 509 forks source link

nvidia-open double fix with nvidia-open-dkms #2517

Closed RageGen closed 4 weeks ago

RageGen commented 1 month ago

Fixing package duplication when installing nvidia-open driver, which is unnecessary because one of the packages is already present. In this case, nvidia-open and nvidia-open-dkms duplicate each other, which can lead to misunderstandings among inexperienced users when installing through a script and using a kernel other than generic linux.

svartkanin commented 1 month ago

This change will break the code as the removed package is still being assigned https://github.com/archlinux/archinstall/pull/2517/files#diff-d39c5771ecacdcd8a8216c41e300b2c0df140c7a871e99f2b29994a85b78cc86L120

According to https://wiki.archlinux.org/title/NVIDIA

Alternatively for the Turing (NV160/TUXXX) series or newer the nvidia-open package may be installed for open source kernel modules on the linux kernel (On other kernels nvidia-open-dkms must be used).

So this may require some more detailed handling of which one to install on Turing series

RageGen commented 1 month ago

@svartkanin I didn’t understand why it violates anything, if in fact, by analogy, everything is done in the same way as with the nvidia package, which is proprietary. After all, only nvidia-dkms is used there, regardless of the kernel.

RageGen commented 1 month ago

@svartkanin I corrected the file, if you meant it. You still haven't justified why in the case of nvidia-open does not work in the same way as in the case of a regular nvidia package. You refer to an article on the wiki, but why? If even when using the script, the pacman itself discards nvidia-open and leaves only its dkms weight.

RageGen commented 1 month ago

@offensive-vk Thank you for your attention to my request!

Torxed commented 4 weeks ago

So the understanding is:

So by removing nvidia-open we would have to rely on nvidia-open-dkms, is this assumption not correct? if it is, then it will add delays and complexity during updates where nvidia-open would have been a better fit?

RageGen commented 4 weeks ago

@Torxed So regardless of the kernel, both packages are installed and in the end only dkms remains, I checked. Then what’s the point? And well, even if as you say, then with the usual nvidia driver, it would be worth doing exactly the same.If your colleague @offensive-vk appreciated this decision, doesn’t that mean it makes sense?

offensive-vk commented 4 weeks ago

@RageGen, Look briefly:

Your assumption is mostly correct , but relying solely on nvidia-open-dkms can complicate and slow down the update process compared to using nvidia-open with the standard kernel.


Lets not hurry on changing this, as it might impact on production scale. so please , Let @Torxed do his work and relax 🤗.
Have a nice day.

RageGen commented 4 weeks ago

Okay, thank you very much, sorry. I thought I’d help. @offensive-vk