search

archlinux / archinstall

Arch Linux installer - guided, templates etc.
GNU General Public License v3.0
6.34k stars 542 forks source link

[master] does not mount encrypted root partition before installing #2793

Closed Torxed closed 1 week ago

Torxed commented 2 weeks ago

Which ISO version are you using?

master

Config

{
    "additional-repositories": [],
    "archinstall-language": "English",
    "audio_config": null,
    "bootloader": "Systemd-boot",
    "config_version": "2.8.6",
    "debug": false,
    "disk_config": {
        "config_type": "default_layout",
        "device_modifications": [
            {
                "device": "/dev/sda",
                "partitions": [
                    {
                        "btrfs": [],
                        "dev_path": null,
                        "flags": [
                            "Boot",
                            "ESP"
                        ],
                        "fs_type": "fat32",
                        "mount_options": [],
                        "mountpoint": "/boot",
                        "obj_id": "3f5204e8-240f-4ff2-a1ec-ceae812a20b6",
                        "size": {
                            "sector_size": {
                                "unit": "B",
                                "value": 512
                            },
                            "unit": "GiB",
                            "value": 1
                        },
                        "start": {
                            "sector_size": {
                                "unit": "B",
                                "value": 512
                            },
                            "unit": "MiB",
                            "value": 1
                        },
                        "status": "create",
                        "type": "primary"
                    },
                    {
                        "btrfs": [],
                        "dev_path": null,
                        "flags": [],
                        "fs_type": "btrfs",
                        "mount_options": [
                            "compress=zstd"
                        ],
                        "mountpoint": "/",
                        "obj_id": "81312b04-4fa1-4f77-8e30-6b623ccf57fb",
                        "size": {
                            "sector_size": {
                                "unit": "B",
                                "value": 512
                            },
                            "unit": "B",
                            "value": 33283899392
                        },
                        "start": {
                            "sector_size": {
                                "unit": "B",
                                "value": 512
                            },
                            "unit": "B",
                            "value": 1074790400
                        },
                        "status": "create",
                        "type": "primary"
                    }
                ],
                "wipe": true
            }
        ]
    },
    "disk_encryption": {
        "encryption_type": "luks",
        "lvm_volumes": [],
        "partitions": [
            "81312b04-4fa1-4f77-8e30-6b623ccf57fb"
        ]
    },
    "hostname": "archlinux",
    "kernels": [
        "linux"
    ],
    "locale_config": {
        "kb_layout": "sv-latin1",
        "sys_enc": "UTF-8",
        "sys_lang": "en_US"
    },
    "mirror_config": {
        "custom_mirrors": [],
        "mirror_regions": {
            "Sweden": [
            ]
        }
    },
    "network_config": {
        "type": "iso"
    },
    "no_pkg_lookups": false,
    "ntp": true,
    "offline": false,
    "packages": [
        "nano",
        "wget"
    ],
    "parallel downloads": 0,
    "profile_config": {
        "gfx_driver": "All open-source",
        "greeter": null,
        "profile": {
            "custom_settings": {
                "Awesome": {}
            },
            "details": [
                "Awesome"
            ],
            "main": "Desktop"
        }
    },
    "save_config": null,
    "script": "guided",
    "silent": false,
    "skip_ntp": false,
    "skip_version_check": false,
    "swap": true,
    "timezone": "UTC",
    "uki": false,
    "version": "2.8.6"
}

Install log

Hardware model detected: QEMU Standard PC (i440FX + PIIX, 1996); UEFI mode: True
Processor model detected: QEMU Virtual CPU version 2.5+
Memory statistics: 3544068 available out of 4004268 total installed
Virtualization detected: kvm; is VM: True
Graphics devices detected: dict_keys(['Device 1234:1111 (rev 02)'])
Disk states before installing: [
    {
        "children": [],
        "fsavail": 0,
        "fsroots": [
            "."
        ],
        "fstype": "squashfs",
        "fsuse_percentage": "100%",
        "fsver": "4.0",
        "log_sec": 512,
        "mountpoint": "/run/archiso/airootfs",
        "mountpoints": [
            "/run/archiso/airootfs"
        ],
        "name": "loop0",
        "partn": null,
        "parttype": null,
        "partuuid": null,
        "path": "/dev/loop0",
        "pkname": null,
        "pttype": null,
        "ptuuid": null,
        "rota": false,
        "size": "877 MiB",
        "tran": null,
        "type": "loop",
        "uuid": null
    },
    {
        "children": [
            {
                "children": [],
                "fsavail": null,
                "fsroots": [],
                "fstype": "vfat",
                "fsuse_percentage": null,
                "fsver": "FAT32",
                "log_sec": 512,
                "mountpoint": null,
                "mountpoints": [],
                "name": "sda1",
                "partn": 1,
                "parttype": "c12a7328-f81f-11d2-ba4b-00a0c93ec93b",
                "partuuid": "11b3f9b1-08d2-407c-b159-7fc01314380e",
                "path": "/dev/sda1",
                "pkname": "sda",
                "pttype": "gpt",
                "ptuuid": "d334846e-ff79-457a-8956-a687e976bd1f",
                "rota": true,
                "size": "1024 MiB",
                "tran": null,
                "type": "part",
                "uuid": "4E81-86FA"
            },
            {
                "children": [],
                "fsavail": null,
                "fsroots": [],
                "fstype": "crypto_LUKS",
                "fsuse_percentage": null,
                "fsver": "2",
                "log_sec": 512,
                "mountpoint": null,
                "mountpoints": [],
                "name": "sda2",
                "partn": 2,
                "parttype": "4f68bce3-e8cd-4db1-96e7-fbcaf984b709",
                "partuuid": "ffcc359a-ca5e-48b2-8f47-85579502392e",
                "path": "/dev/sda2",
                "pkname": "sda",
                "pttype": "gpt",
                "ptuuid": "d334846e-ff79-457a-8956-a687e976bd1f",
                "rota": true,
                "size": "31742 MiB",
                "tran": null,
                "type": "part",
                "uuid": "a50b86c7-38a9-4a20-bd99-2cd2e61b0d99"
            }
        ],
        "fsavail": null,
        "fsroots": [],
        "fstype": null,
        "fsuse_percentage": null,
        "fsver": null,
        "log_sec": 512,
        "mountpoint": null,
        "mountpoints": [],
        "name": "sda",
        "partn": null,
        "parttype": null,
        "partuuid": null,
        "path": "/dev/sda",
        "pkname": null,
        "pttype": "gpt",
        "ptuuid": "d334846e-ff79-457a-8956-a687e976bd1f",
        "rota": true,
        "size": "32768 MiB",
        "tran": null,
        "type": "disk",
        "uuid": null
    },
    {
        "children": [],
        "fsavail": 0,
        "fsroots": [
            "."
        ],
        "fstype": "iso9660",
        "fsuse_percentage": "100%",
        "fsver": "Joliet Extension",
        "log_sec": 2048,
        "mountpoint": "/run/archiso/bootmnt",
        "mountpoints": [
            "/run/archiso/bootmnt"
        ],
        "name": "sr0",
        "partn": null,
        "parttype": null,
        "partuuid": null,
        "path": "/dev/sr0",
        "pkname": null,
        "pttype": "dos",
        "ptuuid": "bc562106",
        "rota": false,
        "size": "1220 MiB",
        "tran": "ata",
        "type": "rom",
        "uuid": "2024-11-09-10-23-44-00"
    }
]
Checking version...
Failed determine pacman version: ['/usr/bin/pacman', '-Qu', 'archinstall'] exited with abnormal exit code [1]: error: package 'archinstall' was not found
warning: 'archinstall' is a file, you might want to use -p/--file.
[?25l[?25h
    score: 2
Loaded mirror mirror.aarnet.edu.au with current score of 2
    score: 5
...
    score: 2
Loaded mirror repo.c48.uk with current score of 2
    score: 4
Loaded mirror repo.c48.uk with current score of 4
    score: 1
Loaded mirror f.matthieul.dev with current score of 1
    score: 3
Loaded mirror mirrors.nepalicloud.com with current score of 3
    score: 3
Loaded mirror mirrors.nepalicloud.com with current score of 3
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/__init__.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/custom.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktop.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/minimal.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/server.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/tailored.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/xorg.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/applications/__init__.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/applications/pipewire.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/__init__.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/awesome.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/bspwm.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/budgie.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/cinnamon.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/cosmic.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/cutefish.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/deepin.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/enlightenment.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/gnome.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/hyprland.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/i3.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/lxqt.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/mate.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/plasma.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/qtile.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/sway.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/desktops/xfce4.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/__init__.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/cockpit.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/docker.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/httpd.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/lighttpd.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/mariadb.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/nginx.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/postgresql.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/sshd.py
Importing profile: /usr/lib/python3.12/site-packages/archinstall/default_profiles/servers/tomcat.py

Unmounting all existing partitions: /dev/sda
Unmounting: /dev/sda1
Unmounting: /dev/sda2
Wiping partitions and metadata: /dev/sda
Erasing luks partition: /dev/sda2
Creating partitions: /dev/sda
    Type: primary
    Filesystem: fat32
    Geometry: 2048 start sector, 2097152 length
    Type: primary
    Filesystem: btrfs
    Geometry: 2099200 start sector, 65007616 length
Formatting filesystem: mkfs.fat -F 32 /dev/sda1
partition information found: {'name': 'sda1', 'path': '/dev/sda1', 'pkname': 'sda', 'size': '1024 MiB', 'log_sec': 512, 'pttype': 'gpt', 'ptuuid': 'cd652586-48b6-4059-a561-80e945a9c2e4', 'rota': True, 'tran': None, 'partn': 1, 'partuuid': '6cde8fc1-6704-4b4f-8746-6ea755667c60', 'parttype': 'c12a7328-f81f-11d2-ba4b-00a0c93ec93b', 'uuid': '6D82-8568', 'fstype': 'vfat', 'fsver': 'FAT32', 'fsavail': None, 'fsuse_percentage': None, 'type': 'part', 'mountpoint': None, 'mountpoints': [], 'fsroots': [], 'children': []}
Luks2 encrypting: /dev/sda2
cryptsetup format: /usr/bin/cryptsetup --batch-mode --verbose --type luks2 --pbkdf argon2id --hash sha512 --key-size 512 --iter-time 10000 --key-file /tmp/sda2.disk_pw --use-urandom luksFormat /dev/sda2
cryptsetup luksFormat output: Existing 'crypto_LUKS' superblock signature on device /dev/sda2 will be wiped.
Existing 'crypto_LUKS' superblock signature on device /dev/sda2 will be wiped.
Key slot 0 created.
Command successful.
Unlocking luks2 device: /dev/sda2
cryptsetup open output: 
luks2 formatting mapper dev: /dev/mapper/ainstsda2
Formatting filesystem: mkfs.btrfs -f /dev/mapper/ainstsda2
luks2 locking device: /dev/sda2
Closing crypt device ainstsda2
partition information found: {'name': 'sda2', 'path': '/dev/sda2', 'pkname': 'sda', 'size': '31742 MiB', 'log_sec': 512, 'pttype': 'gpt', 'ptuuid': 'cd652586-48b6-4059-a561-80e945a9c2e4', 'rota': True, 'tran': None, 'partn': 2, 'partuuid': 'edeb105c-b716-41e5-b734-7fca4b90e618', 'parttype': '4f68bce3-e8cd-4db1-96e7-fbcaf984b709', 'uuid': 'c603d4b3-981f-4f44-b6a8-3473f0035b4f', 'fstype': 'crypto_LUKS', 'fsver': '2', 'fsavail': None, 'fsuse_percentage': None, 'type': 'part', 'mountpoint': None, 'mountpoints': [], 'fsroots': [], 'children': []}
Creating subvolumes: /dev/sda2
Unlocking luks2 device: /dev/sda2
cryptsetup open output: 
Mounting /dev/mapper/ainstsda2: mount -o compress=zstd /dev/mapper/ainstsda2 /mnt/arch_btrfs
Partition /dev/mapper/ainstsda2 is currently mounted at: ['/mnt/arch_btrfs']
Unmounting mountpoint: /mnt/arch_btrfs
Closing crypt device ainstsda2
Starting installation...
Mounting ordered layout
Unlocking luks2 device: /dev/sda2
cryptsetup open output: 
Mounting partition layout
Mounting /dev/sda1: mount /dev/sda1 /mnt/archinstall/boot
Waiting for time sync (timedatectl show) to complete.
Waiting for automatic mirror selection (reflector) to complete.
Waiting for Arch Linux keyring sync (archlinux-keyring-wkd-sync) to complete.
Setting mirrors
Mirrorlist: 

## Sweden
Server = http://ftp.lysator.liu.se/pub/archlinux/$repo/os/$arch

## Sweden
Server = https://ftp.lysator.liu.se/pub/archlinux/$repo/os/$arch

## Sweden
Server = http://ftp.myrveln.se/pub/linux/archlinux/$repo/os/$arch

## Sweden
Server = https://ftp.myrveln.se/pub/linux/archlinux/$repo/os/$arch

## Sweden
Server = http://mirror.accum.se/mirror/archlinux/$repo/os/$arch

## Sweden
Server = https://mirror.accum.se/mirror/archlinux/$repo/os/$arch

## Sweden
Server = https://mirror.osbeck.com/archlinux/$repo/os/$arch

## Sweden
Server = http://ftpmirror.infania.net/mirror/archlinux/$repo/os/$arch

## Sweden
Server = http://mirror.bahnhof.net/pub/archlinux/$repo/os/$arch

## Sweden
Server = https://mirror.bahnhof.net/pub/archlinux/$repo/os/$arch

## Sweden
Server = https://mirror.braindrainlan.nu/archlinux/$repo/os/$arch

Archinstall will not install any ucode.
The multilib flag is not set. This system will be installed without multilib repositories enabled.
The testing flag is not set. This system will be installed without testing repositories enabled.
Installing packages: ['base', 'base-devel', 'linux-firmware', 'linux', 'btrfs-progs']
Could not strap in packages: ['/usr/bin/pacstrap', '-C', '/etc/pacman.conf', '-K', '/mnt/archinstall', 'base', 'base-devel', 'linux-firmware', 'linux', 'btrfs-progs', '--noconfirm'] exited with abnormal exit code [1]: zstd-1.5.6-1
               base-3-2  base-devel-1-2  btrfs-progs-6.11-1
               linux-6.11.6.arch1-1  linux-firmware-20241017.22a6c7dc-1

Total Download Size:    622.02 MiB
Total Installed Size:  1379.02 MiB

:: Proceed with installation? [Y/n] 
error: Partition / too full: 162595 blocks needed, 55644 blocks free
error: failed to commit transaction (not enough free disk space)
Errors occurred, no packages were upgraded.
[?25h==> ERROR: Failed to install packages to new root

Mounts during install

proc on /proc type proc (rw,nosuid,nodev,noexec,relatime)
sys on /sys type sysfs (rw,nosuid,nodev,noexec,relatime)
dev on /dev type devtmpfs (rw,nosuid,relatime,size=1921652k,nr_inodes=480413,mode=755,inode64)
run on /run type tmpfs (rw,nosuid,nodev,relatime,mode=755,inode64)
efivarfs on /sys/firmware/efi/efivars type efivarfs (rw,nosuid,nodev,noexec,relatime)
/dev/sr0 on /run/archiso/bootmnt type iso9660 (ro,relatime,nojoliet,check=s,map=n,blocksize=2048,iocharset=utf8)
cowspace on /run/archiso/cowspace type tmpfs (rw,relatime,size=262144k,mode=755,inode64)
/dev/loop0 on /run/archiso/airootfs type squashfs (ro,relatime,errors=continue,threads=single)
airootfs on / type overlay (rw,relatime,lowerdir=/run/archiso/airootfs,upperdir=/run/archiso/cowspace/persistent_/x86_64/upperdir,workdir=/run/archiso/cowspace/persistent_/x86_64/workdir,uuid=on)
securityfs on /sys/kernel/security type securityfs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /dev/shm type tmpfs (rw,nosuid,nodev,inode64)
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000)
cgroup2 on /sys/fs/cgroup type cgroup2 (rw,nosuid,nodev,noexec,relatime,nsdelegate,memory_recursiveprot)
pstore on /sys/fs/pstore type pstore (rw,nosuid,nodev,noexec,relatime)
bpf on /sys/fs/bpf type bpf (rw,nosuid,nodev,noexec,relatime,mode=700)
systemd-1 on /proc/sys/fs/binfmt_misc type autofs (rw,relatime,fd=39,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=3557)
mqueue on /dev/mqueue type mqueue (rw,nosuid,nodev,noexec,relatime)
tracefs on /sys/kernel/tracing type tracefs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /tmp type tmpfs (rw,nosuid,nodev,size=2002136k,nr_inodes=1048576,inode64)
debugfs on /sys/kernel/debug type debugfs (rw,nosuid,nodev,noexec,relatime)
hugetlbfs on /dev/hugepages type hugetlbfs (rw,nosuid,nodev,relatime,pagesize=2M)
tmpfs on /run/credentials/systemd-journald.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/systemd-network-generator.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/systemd-udev-load-credentials.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
fusectl on /sys/fs/fuse/connections type fusectl (rw,nosuid,nodev,noexec,relatime)
configfs on /sys/kernel/config type configfs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /run/credentials/systemd-tmpfiles-setup-dev-early.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/systemd-sysctl.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/systemd-sysusers.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/systemd-tmpfiles-setup-dev.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /etc/pacman.d/gnupg type tmpfs (rw,relatime,mode=755,inode64,noswap)
tmpfs on /run/credentials/systemd-tmpfiles-setup.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/systemd-networkd.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/systemd-firstboot.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/systemd-resolved.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/getty@tty1.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/user/0 type tmpfs (rw,nosuid,nodev,relatime,size=400424k,nr_inodes=100106,mode=700,inode64)
tmpfs on /run/credentials/systemd-vconsole-setup.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
/dev/sda1 on /mnt/archinstall/boot type vfat (rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=ascii,shortname=mixed,utf8,errors=remount-ro)
tmpfs on /run/credentials/getty@tty2.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
tmpfs on /run/credentials/getty@tty3.service type tmpfs (ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap)
svartkanin commented 2 weeks ago

@Torxed there's no btrfs subvolumes specified, looking at the logs it shows 

Mounting ordered layout
Unlocking luks2 device: /dev/sda2
cryptsetup open output: 
Mounting partition layout

So it's correctly unlocking the / root partition, then this code should be executed https://github.com/archlinux/archinstall/blob/master/archinstall/lib/installer.py#L336-L343

which will mount the relevant btrfs subvolumes, but in your config no subvolumes were specified. Is this not correct?

Torxed commented 2 weeks ago

Weird, I basically did a "next next finish" installation and selected all the defaults. So that would probably mean that some of the selected options isn't behaving expectedly.

I'll record all the steps in a bit.

svartkanin commented 2 weeks ago

@Torxed I recorded the btrfs selection in master and it seems to provide the correct layout when selecting the default one https://github.com/user-attachments/assets/ddd51480-acb3-4625-8d95-8750ff648fc7

Torxed commented 1 week ago

I finally managed to get around to recording the issue and it's reproducible for me:

asciicast

It's when I don't select subvolumes that the partition doesn't get mounted (using encryption, if that matters).

If I use subvolumes, then they get mounted correctly.

svartkanin commented 1 week ago

@Torxed isn't that what I mentioned here https://github.com/archlinux/archinstall/issues/2793#issuecomment-2466476359?

If you choose btrfs and don't specify subvolumes what is the desired behaviour?

Just as a side note I think this behaviour has been there for a while, not saying it's correct but that it might not be a release blocker in that case?

Torxed commented 1 week ago

@Torxed isn't that what I mentioned here https://github.com/archlinux/archinstall/issues/2793#issuecomment-2466476359?

Indeed, I didn't fully understand until today. It used to be that the default menu option was yes for:

"Do you wish to use subvolumes"?

Which is probably why I got thrown off a bit of why it didn't create the subvolumes (as I didn't read obviously what I was selecting).

Just as a side note I think this behaviour has been there for a while

Just tested to be sure and the current stable release mounts the btrfs partition as a normal partition:

screenshot

So something has changed between 2.8.6 and master that broke this mount behavior. And this being the 2.8.6 config without subvolumes:

{
    "__separator__": null,
    "additional-repositories": [],
    "archinstall-language": "English",
    "audio_config": null,
    "bootloader": "Systemd-boot",
    "config_version": "2.8.6",
    "debug": false,
    "disk_config": {
        "config_type": "default_layout",
        "device_modifications": [
            {
                "device": "/dev/sda",
                "partitions": [
                    {
                        "btrfs": [],
                        "dev_path": null,
                        "flags": [
                            "Boot",
                            "ESP"
                        ],
                        "fs_type": "fat32",
                        "mount_options": [],
                        "mountpoint": "/boot",
                        "obj_id": "297b0f69-7111-4fb8-bdc5-1d056c9e82c5",
                        "size": {
                            "sector_size": {
                                "unit": "B",
                                "value": 512
                            },
                            "unit": "GiB",
                            "value": 1
                        },
                        "start": {
                            "sector_size": {
                                "unit": "B",
                                "value": 512
                            },
                            "unit": "MiB",
                            "value": 1
                        },
                        "status": "create",
                        "type": "primary"
                    },
                    {
                        "btrfs": [],
                        "dev_path": null,
                        "flags": [],
                        "fs_type": "btrfs",
                        "mount_options": [
                            "compress=zstd"
                        ],
                        "mountpoint": "/",
                        "obj_id": "0f4064ae-8523-429e-9cf2-442fb0848095",
                        "size": {
                            "sector_size": {
                                "unit": "B",
                                "value": 512
                            },
                            "unit": "B",
                            "value": 33283899392
                        },
                        "start": {
                            "sector_size": {
                                "unit": "B",
                                "value": 512
                            },
                            "unit": "B",
                            "value": 1074790400
                        },
                        "status": "create",
                        "type": "primary"
                    }
                ],
                "wipe": true
            }
        ]
    },
    "disk_encryption": null,
    "hostname": "archlinux",
    "kernels": [
        "linux"
    ],
    "locale_config": {
        "kb_layout": "sv-latin1",
        "sys_enc": "UTF-8",
        "sys_lang": "en_US"
    },
    "mirror_config": {
        "custom_mirrors": [],
        "mirror_regions": {
            "Sweden": [
                "https://mirror.osbeck.com/archlinux/$repo/os/$arch",
                "https://mirror.braindrainlan.nu/archlinux/$repo/os/$arch",
                "http://ftp.myrveln.se/pub/linux/archlinux/$repo/os/$arch",
                "http://mirror.accum.se/mirror/archlinux/$repo/os/$arch",
                "https://ftp.myrveln.se/pub/linux/archlinux/$repo/os/$arch",
                "https://mirror.accum.se/mirror/archlinux/$repo/os/$arch",
                "http://mirror.bahnhof.net/pub/archlinux/$repo/os/$arch",
                "https://mirror.bahnhof.net/pub/archlinux/$repo/os/$arch",
                "http://ftpmirror.infania.net/mirror/archlinux/$repo/os/$arch",
                "http://ftp.lysator.liu.se/pub/archlinux/$repo/os/$arch",
                "https://ftp.lysator.liu.se/pub/archlinux/$repo/os/$arch"
            ]
        }
    },
    "network_config": {},
    "no_pkg_lookups": false,
    "ntp": true,
    "offline": false,
    "packages": [],
    "parallel downloads": 0,
    "profile_config": null,
    "save_config": null,
    "script": "guided",
    "silent": false,
    "skip_ntp": false,
    "skip_version_check": false,
    "swap": true,
    "timezone": "UTC",
    "uki": false,
    "version": "2.8.6"
}
codefiles commented 1 week ago

This is a regression caused by b470b16e.

svartkanin commented 1 week ago

@Torxed I'll try to have a look at it today

codefiles commented 1 week ago

Too late to solve the problem but please review the pull request!

Torxed commented 1 week ago

I was just about to say that I can only reproduce this if I use encryption ontop of BTRFS without subvolumes. I'll test the PR in the morning as it's getting quite late here.