search

archlinux / archinstall

Arch Linux installer - guided, templates etc.
GNU General Public License v3.0
6.14k stars 531 forks source link

Timeshift restore failing #918

Open AshleighWilson opened 2 years ago

AshleighWilson commented 2 years ago

Hi,

I've been testing release 2.3.1, specifically with timeshift. I have found an issue where the system will not boot after restoring a @home subvolume. The error from the system logs is arch kernel: BTRFS error (device vda2): subvol '/@home' does not match subvolid 258..

From Here, I believe this is due to /etc/fstab specifying a subvolid as well as subvol. I've tested removing the subvolid from /etc/fstab and the system boots fine.

I am not sure if this will result in other issues, but is it possible to remove subvolid from the generated /etc/fstab configuration?

Thanks.

Torxed commented 2 years ago

Thank you for reporting and testing this! We generally avoid touching /etc/fstab and we rely on genfstab.

I suspect that this fix may lead to other issues for other tools (maybe) like snapper or systemd-mount?

Perhaps the timeshift wiki should be updated with a note, or we implement a timeshift profiles/applications that does this?

wllacer commented 2 years ago

I can confirm that our code DOES NOT use subvolid

mirsella commented 2 years ago

I can confirm that our code DOES NOT use subvolid

it means that @AshleighWilson's /etc/fstab with a subvolid was not intended to be created by archinstall, or that we can just stop generating etc/fstab with a subvolid ?

KhalilSantana commented 2 years ago

It's very likely an issue with genfstab itself, when you run it on any system with subvolumes it will list both the subvol path and the subvolid on the generated fstab entry, which is not only ugly to look at and redundant, but also makes rolling back manually (via mounting toplevel and moving+snapping stuff) harder.