change to git-show for condition check

archlinux / asp

Arch Build Source Management Tool

MIT License

294 stars 34 forks source link

change to git-show for condition check #28

Closed ThePiGrepper closed 5 years ago

ThePiGrepper commented 5 years ago

fixup: 0a6a4d0 Use exit status rather than string emptiness

git-ls always returns 0 as exit status, so it can't be used as a check. However, git-show does return an error status.

falconindy commented 5 years ago

Ah interesting. git ls-tree fails when the ref isn't found, but not when the tree object isn't found. This is probably why used the [[ -z $(...) ]] syntax in the first place.

Thanks!