rebuild-todo: Various improvements

archlinux / contrib

Arch contrib scripts

GNU General Public License v2.0

64 stars 19 forks source link

rebuild-todo: Various improvements #74

Closed Antiz96 closed 3 months ago

Antiz96 commented 3 months ago

Print a message during the packages list parsing (to avoid thinking the script is just stuck)
Improve the "confirm" message: fixes https://github.com/archlinux/contrib/issues/54

2024-07-04_23-00

Don't exit on failed release
Show the exact list of skipped packages (that failed to build), rebuilt packages (but unreleased) and released packages when done: fixes https://github.com/archlinux/contrib/issues/53

2024-07-04_23-21

Antiz96 commented 3 months ago

Are we interested in an additional listing for released packages as well (which is a separate step from rebuilding)? There can be some (rather edgy but still existing) cases where the build can success but not the release/publish.

If you feel that could be interesting, I can add it to that PR.

alerque commented 3 months ago

The edge case of failed releases for successful builds may be useful, but ever more useful to me would be a list of failed (skipped) builds. Two lists here would be really nice: skipped & built/published. Or three if you do add the other feature: skipped, built (e.g. only built not published), and published.

Antiz96 commented 3 months ago

The edge case of failed releases for successful builds may be useful, but ever more useful to me would be a list of failed (skipped) builds. Two lists here would be really nice: skipped & built/published. Or three if you do add the other feature: skipped, built (e.g. only built not published), and published.

The 3 lists thing should be doable (skipped, built only but not published, and published). I'll try to work on that when I can. Thanks for the suggestion :) I'm converting this PR as a draft in the mean time.

Foxboron commented 3 months ago

Cool, this looks great :) Thanks!