search

archlinuxcn / lilac

Lilac is the build bot for archlinuxcn
GNU General Public License v3.0
113 stars 40 forks source link

added `--noprepare` in vcs_update() #124

Closed petronny closed 4 years ago

petronny commented 4 years ago

如题，我觉得是没必要运行prepare()的。。。

lilydjwg commented 4 years ago

原来还有这么个选项。

yan12125 commented 4 years ago

This change breaks linux-jwrdegoede [1]:

/home/lilydjwg/archgitrepo/archlinuxcn/linux-jwrdegoede/PKGBUILD: 第 36 行：cd: linux-sunxi: 没有那个文件或目录 ==> 错误： pkgver 不允许为空。

In the corresponding PKGBUILD, prepare() clones the main git repo [2], and thus skipping prepare() breaks vcs_update().

For this specific case, I think PKGBUILD should be modified. /cc @farseerfc

[1] https://build.archlinuxcn.org/~yan12125/lilac-log/2019-09-06T01%3A17%3A01 [2] https://github.com/archlinuxcn/repo/blob/39653b606736cef6d16fb338418ffe9ed94d2640/archlinuxcn/linux-jwrdegoede/PKGBUILD#L47

lilydjwg commented 4 years ago

@masakichi 的 mecab-ipadic-neologd-git 也有在 prepare 进行 git clone 的问题呢。

farseerfc commented 4 years ago

@yan12125 thanks, I am trying to revert to normal git repo in source array