search

archlinuxcn / lilac

Lilac is the build bot for archlinuxcn
GNU General Public License v3.0
113 stars 39 forks source link

add_xxx functions break string substitutions #164

Closed DDoSolitary closed 3 years ago

DDoSolitary commented 3 years ago

For example, the lib32-fltk AUR package has "${pkgname#lib32-}" in its depends array. If I call add_depends() when building this package, it goes broken because the double quotes are blindly replaced by single quotes by _add_into_array.

DDoSolitary commented 3 years ago

One quick but ugly solution: always use double quotes in _add_into_array. I guess it is OK because it is very unlikely that a package has special characters in its dependencies.

Or we need rewrite the parsing part to save the quotes used in the original file.

lilydjwg commented 3 years ago

Switching to double quotes sounds fine to me.