search

archlinuxcn / lilac

Lilac is the build bot for archlinuxcn
GNU General Public License v3.0
113 stars 39 forks source link

Implement rpkgs nvchecker source for CRAN and Bioconductor #201

Closed pekkarr closed 1 year ago

pekkarr commented 1 year ago

This source fetches and caches the PACKAGES.gz file of the repo.

Optimized and expanded from lilydjwg/nvchecker#184

pekkarr commented 1 year ago

Tests and the better error message are now implemented.

Also, should we deprecate the cran source?

In my opinion, no. The cran source is lightweight for checking a few versions, since it fetches the version info only for the requested packages unlike rpkgs which fetches the whole version database.

Quoting comment from https://github.com/lilydjwg/nvchecker/pull/184#issuecomment-853557501

However, I don't quite like to download the whole database just for a few entries. Even crawling the web page is better than that.

In lilac it makes sense to download the whole database, since there are almost 4000 R packages in the Bioarchlinux repo. For other nvchecker users this might not be the case.

And besides, this source is in lilac (unless you want me to make a pr for nvchecker?)

lilydjwg commented 1 year ago

Oops, I didn't notice it's the lilac repo here. Let's keep it with lilac for the time being.

lilydjwg commented 3 months ago

The tests need an update: https://github.com/archlinuxcn/lilac/actions/runs/8402877668/job/23012743437

pekkarr commented 3 months ago

The tests pass on my machine, and also on the BioArchLinux build.

In the GitHub actions job, it looks like curl can't find or access the certificate store. I'm not sure how to fix this.

tornado.curl_httpclient.CurlError: HTTP 599: error setting certificate verify locations:
  CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
lilydjwg commented 3 months ago

Oh I see. The same issue I've fixed for nvchecker repo.