archlinuxcn / lilac

Lilac is the build bot for archlinuxcn
GNU General Public License v3.0
113 stars 39 forks source link

[bugfix] avoid `more_pkgs` being updated during iteration #204

Closed SamLukeYes closed 10 months ago

SamLukeYes commented 10 months ago

Previously, the set more_pkgs in function main_may_raise can be updated during iteration, which leads to RuntimeError and crashes lilac. The bug can be triggered when a package with update_on_build specified in lilac.yaml is referenced in another update_on_build array. This PR is a minimal refactor to fix the issue.

lilydjwg commented 10 months ago

Thanks!