search

archlinuxcn / lilac

Lilac is the build bot for archlinuxcn
GNU General Public License v3.0
114 stars 40 forks source link

Add setup.py #78

Closed Xuanwo closed 4 years ago

Xuanwo commented 5 years ago

fix https://github.com/archlinuxcn/lilac/issues/35 .

lilydjwg commented 5 years ago

Where will pypi2pkgbuild and recv_gpg_keys be installed? And what about config.ini.sample?

Xuanwo commented 5 years ago

Maybe we should change the current behavior for may_download_winterpy_libs which will lead to NotADirectoryError: [Errno 20] Not a directory error while running lilac.

winterpy should under control of git submodule or via pip instead of downloading directly.

lilydjwg commented 5 years ago

I prefer to vendor them.

lilydjwg commented 5 years ago

Vendored。

Xuanwo commented 5 years ago

How about remove the sys.path.append from lilac, and use vendor.myutils instead ?

lilydjwg commented 5 years ago

How about remove the sys.path.append from lilac, and use vendor.myutils instead ?

It's better but needs a lot of work to update all imports. Also it's better to do as lilac2.vendor.xxx.

Xuanwo commented 5 years ago

What's the relation between lilac2, lilaclib, pylib and vendor ?

Maybe we can move all code into a split package, and keep lilac as a simple script to call them? If you agree, I can submit a draft and finish the refactor for that.

lilydjwg commented 5 years ago

lilaclib is the old one, lilac2 is a refactoring one. vendor is utils from winterpy (called pylib previously).

It's not easy to move them together.

lilydjwg commented 5 years ago

I tried but it doesn't work out. I need to put winterpy libs in a single package first...

yan12125 commented 4 years ago

Hi @Xuanwo are you still working on this? If not, may I finish this based on your work?

Xuanwo commented 4 years ago

@yan12125 It will be great if you can continue on this!

yan12125 commented 4 years ago

Thanks!