Rebuild package chromium-dev with vaapi patch? if possible =)) (Included: a rough sample of a new PKGBUILD)

kj-sh604 commented 7 years ago

Hi,

Again, thank you for maintaining this really awesome repo. Really helps me alot as a web-developer.

Chromium-dev in the AUR used to be compiled with the VAAPI patch; however; ever since the 55.0.XXXX.Y-Z release the patch is disabled by default as indicated by the maintainer, sl1pkn07

"Now pushed the option for enable the vaapi patch (disabled by default, to enable, you need set 1 the option _patch_vaapi in the PKGBUILD)"

I believe that's in line 17

The VAAPI patch is something, I believe, will benefit the people downloading chromium-dev from this repo, including me of course

New PKGBUILD should look something like this... Hope it compiles =))

# Maintainer: Gustavo Alvarez <sl1pkn07@gmail.com>
# Contributor: Mikhail Vorozhtsov <mikhail.vorozhtsov@gmail.com>
# Contributor: Nagisa <simonas@kazlauskas.me>
# Contributor: Misc <andreas.reis@gmail.com>
# Contributor: Jeagoss <jgoliver@jeago.com>
# Contributor: Saikrishna Arcot <saiarcot895@gmail.com> (Author of enable_vaapi_on_linux.diff)

#########################
## -- Build options -- ##
#########################

_use_clang=1           # Use clang compiler (downloaded binaries from google). Results in faster build and smaller chromium.
_use_ccache=0          # Use ccache when build.
_use_pax=0             # Set 1 to change PaX permisions in executables NOTE: only use if use PaX environment.
_use_gtk3=1            # If set 1, then build with GTK3 support, if set 0, then build with GTK2.
_debug_mode=0          # Build in debug mode.
_patch_vaapi=1         # Apply the vaapi patch by Saikrishna Arcot.

##############################################
## -- Package and components information -- ##
##############################################
pkgname=chromium-dev
pkgver=55.0.2873.4
_launcher_ver=3
pkgrel=1
pkgdesc="The open-source project behind Google Chrome (Dev Channel)"
arch=('i686' 'x86_64')
url='http://www.chromium.org'
license=('BSD')
depends=('desktop-file-utils'
         'jsoncpp'
#          'libsrtp'
         'libwebp'
         'libxslt'
         'libxss'
         'minizip'
         'perl-file-basedir'
         'nss'
         'pciutils'
         're2'
         'snappy'
         'speech-dispatcher'
         'speex'
         'xdg-utils'
#          'opus'
#          'protobuf'
#          'libevent'
         'libvpx.so'
         'ffmpeg'
         )
makedepends=('libexif'
             'elfutils'
             'gperf'
             'ninja'
             'perl-json'
             'python2-beautifulsoup4'
             'python2-html5lib'
             'python2-simplejson'
             'python2-jinja'
             'python2-ply'
             'subversion'
             'yasm'
             'git'
             'imagemagick'
             'hwids'
             )
optdepends=('pepper-flash: PPAPI Flash Player'
            'chromium-widevine-dev: Widevine plugin (eg: Netflix) (Dev Channel)'
            #
            'kdebase-kdialog: Needed for file dialogs in KDE4/KF5'
            'kdialog-git: Needed for file dialogs in KF5'
            #
            'kwalletmanager: Needed for storing passwords in KWallet'
            #
            'libexif: Need for read EXIF metadata'
            'ttf-font: For some typography'
            )
source=( #"https://gsdview.appspot.com/chromium-browser-official/chromium-${pkgver}.tar.xz"
        "https://commondatastorage.googleapis.com/chromium-browser-official/chromium-${pkgver}.tar.xz"
        "chromium-launcher-${_launcher_ver}.tar.gz::https://github.com/foutrelis/chromium-launcher/archive/v${_launcher_ver}.tar.gz"
        'chromium-dev.svg'
        'BUILD.gn'
        # Patch form Gentoo
        'https://raw.githubusercontent.com/gentoo/gentoo/master/www-client/chromium/files/chromium-system-ffmpeg-r4.patch'
        'https://raw.githubusercontent.com/gentoo/gentoo/master/www-client/chromium/files/chromium-system-jinja-r14.patch'
        'https://raw.githubusercontent.com/gentoo/gentoo/master/www-client/chromium/files/chromium-system-zlib-r1.patch'
        'https://raw.githubusercontent.com/gentoo/gentoo/master/www-client/chromium/files/chromium-gn-r7.patch'
        # Misc Patches
        'https://launchpad.net/~saiarcot895/+archive/ubuntu/chromium-dev/+files/chromium-browser_55.0.2868.3-0ubuntu1~ppa2~16.10.1.debian.tar.xz'
        'minizip.patch::http://pastebin.com/raw/QCqSDam5'
        'unset-madv_free.patch'
        # Patch from crbug (chromium bugtracker)
        'chromium-widevine-r1.patch'
        )
sha256sums=( #"$(curl -sL https://gsdview.appspot.com/chromium-browser-official/chromium-55.0.2873.0.tar.xz.hashes | grep sha256 | cut -d ' ' -f3)"
            "$(curl -sL https://commondatastorage.googleapis.com/chromium-browser-official/chromium-${pkgver}.tar.xz.hashes | grep sha256 | cut -d ' ' -f3)"
            '8b01fb4efe58146279858a754d90b49e5a38c9a0b36a1f84cbb7d12f92b84c28'
            'dd2b5c4191e468972b5ea8ddb4fa2e2fa3c2c94c79fc06645d0efc0e63ce7ee1'
            'c7d9974834fc3803b5f1a1d310ff391306964caaabc807a62f8e5c3d38526ee6'
            # Patch form Gentoo
            'e3c474dbf3822a0be50695683bd8a2c9dfc82d41c1524a20b4581883c0c88986'
            'a9cb08fbac8ffcf6371edd7ab67833efd42c5b92938f1e2e7922d1d22d226db8'
            '9e7bd19f8ee7a67393d0f7f50f5f27e52cb943602107d3784a28f31cf684748c'
            '90cb9498355c420b5b81873d4339a8fe45e96b206296968ea5f01b5a7de16b78'
            # Misc Patches
            'd5df04b9a828e9449309ef021be824344fb26bc9ce3955c292ad160c2613b82c'
            'c1131b4f969d4ff20208aa26bada30b75752c1c18853a2aa41d40901f53c8f31'
            '3b3aa9e28f29e6f539ed1c7832e79463b13128863a02e9c6fecd16c30d61c227'
            # Patch from crbug (chromium bugtracker)
            '0d537830944814fe0854f834b5dc41dc5fc2428f77b2ad61d4a5e76b0fe99880'
            )
options=('!strip')
install=chromium-dev.install
noextract=('chromium-browser_55.0.2868.3-0ubuntu1~ppa2~16.10.1.debian.tar.xz')

################################################
## -- Don't touch anything below this line -- ##
################################################

# Build Debug mode?.
if [ "${_debug_mode}" = "1" ]; then
  _debug_flag="symbol_level=1"
  _strip=false
elif [ "${_debug_mode}" = "0" ]; then
  _strip=true
fi

# Google API keys (see http://www.chromium.org/developers/how-tos/api-keys)
# NOTE: These are for Arch Linux use ONLY. For your own distribution, please
# get your own set of keys. Feel free to contact foutrelis@archlinux.org for
# more information.
_google_api_key="AIzaSyDwr302FpOSkGRpLlUpPThNTDPbXcIn_FM"
_google_default_client_id="413772536636.apps.googleusercontent.com"
_google_default_client_secret="0ZChLK6AxeA3Isu96MkwqDR4"

# Build NaCL?. disabled if detect 32bit system
if [ "${CARCH}" = "i686" ]; then
  _build_nacl=0
  _nacl="false"
elif [ "${CARCH}" = "x86_64" ]; then
  _build_nacl=1
  _nacl="true"
  makedepends+=('ncurses5-compat-libs')
fi

# If use PaX environment.
if [ "${_use_pax}" = "1" ]; then
  makedepends+=('paxctl')
fi

# Build with GTK3?.
if [ "${_use_gtk3}" = "1" ]; then
  depends+=('gtk3')
  _launcher_gtk='GTK=3'
  optdepends+=('libappindicator-gtk3: Needed for show systray icon in the panel in plasma-next (KF5)')
  _gtk3=true
elif [ "${_use_gtk3}" = "0" ]; then
  depends+=('gtk2')
  optdepends+=('libappindicator-gtk2: Needed for show systray icon in the panel in plasma-next (KF5)')
  _gtk3=false
fi

# Need you use ccache?.
if [ "${_use_ccache}" = "1" ]; then
  makedepends+=('ccache')
  export CCACHE_CPP2=yes
  export CCACHE_SLOPPINESS=time_macros
  _ccache='ccache'
fi

# Are you use gnome-keyring/gnome?.
_gnome_keyring=false
if [ -e /usr/lib/security/pam_gnome_keyring.so ]; then
  depends+=('gnome-keyring')
  _gnome_keyring=true
fi

# Are you use Pulseaudio?.
_pulseaudio=false
if [ -e /usr/lib/pulseaudio/libpulsecore-9.0.so ]; then
  depends+=('pulseaudio')
  _pulseaudio=true
fi

# List of third-party components needed for build chromium. The rest is remove by remove_bundled_libraries srcipt in prepare().
_keeplibs=('base/third_party/dmg_fp'
           'base/third_party/dynamic_annotations'
           'base/third_party/icu'
           'base/third_party/libevent'
           'base/third_party/nspr'
           'base/third_party/superfasthash'
           'base/third_party/symbolize'
           'base/third_party/valgrind'
           'base/third_party/xdg_mime'
           'base/third_party/xdg_user_dirs'
           'breakpad/src/third_party/curl'
           'chrome/third_party/mozilla_security_manager'
           'courgette/third_party'
           'native_client/src/third_party/dlmalloc'
           'native_client_sdk/src/libraries/third_party/newlib-extras'
           'net/third_party/mozilla_security_manager'
           'net/third_party/nss'
           'third_party/WebKit'
           'third_party/adobe'
           'third_party/analytics'
           'third_party/angle'
           'third_party/angle/src/common/third_party/numerics'
           'third_party/angle/src/third_party/compiler'
           'third_party/angle/src/third_party/murmurhash'
           'third_party/angle/src/third_party/trace_event'
           'third_party/angle/src/third_party/libXNVCtrl'
           'third_party/boringssl'
           'third_party/brotli'
           'third_party/cacheinvalidation'
           'third_party/catapult'
           'third_party/catapult/third_party/polymer'
           'third_party/catapult/third_party/py_vulcanize'
           'third_party/catapult/third_party/py_vulcanize/third_party/rcssmin'
           'third_party/catapult/third_party/py_vulcanize/third_party/rjsmin'
           'third_party/catapult/tracing/third_party/d3'
           'third_party/catapult/tracing/third_party/gl-matrix'
           'third_party/catapult/tracing/third_party/jszip'
           'third_party/catapult/tracing/third_party/mannwhitneyu'
           'third_party/ced'
           'third_party/cld_2'
           'third_party/cld_3'
           'third_party/cros_system_api'
           'third_party/devscripts'
           'third_party/dom_distiller_js'
           'third_party/fips181'
           'third_party/flatbuffers'
           'third_party/flot'
           'third_party/google_input_tools'
           'third_party/google_input_tools/third_party/closure_library'
           'third_party/google_input_tools/third_party/closure_library/third_party/closure'
           'third_party/hunspell'
           'third_party/iccjpeg'
           'third_party/jstemplate'
           'third_party/khronos'
           'third_party/leveldatabase'
           'third_party/libXNVCtrl'
           'third_party/libaddressinput'
           'third_party/libjingle'
           'third_party/libphonenumber'
           'third_party/libsecret'
           'third_party/libsrtp'
           'third_party/libudev'
           'third_party/libusb'
           'third_party/libva'
           'third_party/libwebm'
           'third_party/libxml/chromium'
           'third_party/libyuv'
           'third_party/lss'
           'third_party/lzma_sdk'
           'third_party/mesa'
           'third_party/modp_b64'
           'third_party/mt19937ar'
           'third_party/openh264'
           'third_party/openmax_dl'
           'third_party/opus'
           'third_party/ots'
           'third_party/pdfium'
           'third_party/pdfium/third_party/agg23'
           'third_party/pdfium/third_party/base'
           'third_party/pdfium/third_party/bigint'
           'third_party/pdfium/third_party/freetype'
           'third_party/pdfium/third_party/lcms2-2.6'
           'third_party/pdfium/third_party/libjpeg'
           'third_party/pdfium/third_party/libopenjpeg20'
           'third_party/pdfium/third_party/libpng16'
           'third_party/pdfium/third_party/libtiff'
           'third_party/pdfium/third_party/zlib_v128'
           'third_party/polymer'
           'third_party/protobuf'
           'third_party/protobuf/third_party/six'
           'third_party/qcms'
           'third_party/sfntly'
           'third_party/skia'
           'third_party/smhasher'
           'third_party/speech-dispatcher'
           'third_party/sqlite'
           'third_party/tcmalloc'
           'third_party/usb_ids'
           'third_party/usrsctp'
           'third_party/web-animations-js'
           'third_party/webdriver'
           'third_party/webrtc'
           'third_party/widevine'
           'third_party/woff2'
           'third_party/x86inc'
           'third_party/xdg-utils'
           'third_party/yasm/run_yasm.py'
           'third_party/zlib/google'
           'url/third_party/mozilla'
           'v8/src/third_party/valgrind'
           )

# Set build flags.

_flags=('is_debug=false'
        'enable_widevine=true'
        'enable_hangout_services_extension=false'
        "ffmpeg_branding=\"ChromeOS\""
        'proprietary_codecs=true'
        "google_api_key=\"${_google_api_key}\""
        "google_default_client_id=\"${_google_default_client_id}\""
        "google_default_client_secret=\"${_google_default_client_secret}\""
        'fieldtrial_testing_like_official_build=false'
        "remove_webcore_debug_symbols=${_strip}"
        'use_gconf=false'
        "use_gio=false"
        "use_gnome_keyring=${_gnome_keyring}"
        "use_gtk3=${_gtk3}"
        "use_pulseaudio=${_pulseaudio}"
        "link_pulseaudio=${_pulseaudio}"
        'use_kerberos=true'
        'use_cups=true'
        'use_sysroot=false'
        'use_gold=false'
        "use_allocator=\"none\""
        'linux_use_bundled_binutils=false'
        'fatal_linker_warnings=false'
        'treat_warnings_as_errors=false'
        "enable_nacl=${_nacl}"
        "enable_nacl_nonsfi=${_nacl}"
        )

# Set the bundled/external components.
# TODO: need ported to GN as GYP doing before. see status page: https://crbug.com/551343
# hunspell
# libusb
# opus
# sqlite
# ssl
# libsrtp
# protobuf

_use_system=('ffmpeg'
             'flac'
             'harfbuzz-ng'
#              'libevent' # Get segfaults and other problems https://bugs.gentoo.org/593458
             'libjpeg'
             'libpng'
             'libvpx'
             'libwebp'
             'libxml'
             'libxslt'
             're2'
             'snappy'
             'yasm'
             'zlib'
             )

# Conditionals.
if [ "${_debug_mode}" = "1" ]; then
  _keeplibs+=('native_client/src/third_party/valgrind')
fi

if [ "${_build_nacl}" = "1" ]; then
  _keeplibs+=('third_party/icu')
elif [ "${_build_nacl}" = "0" ]; then
  depends+=('icu')
  _use_system+=('icu')
fi

################################################

prepare() {

  # Use custom toolchain.
  _flags+=("custom_toolchain=\"${srcdir}:default\"")

  # Set Python2 path.
  mkdir -p python-path
  ln -s /usr/bin/python2 "${srcdir}/python-path/python"
  export PATH="${srcdir}/python-path:$PATH"

  cd "chromium-${pkgver}"

  # Fix to save configuration in ~/.config/chromium-dev.
  sed -e 's|filename = "chromium-browser"|filename = "chromium-dev"|' \
      -e 's|confdir = "chromium"|confdir = "chromium-dev"|' \
      -i chrome/BUILD.gn
  sed -e 's|config_dir.Append("chromium")|config_dir.Append("chromium-dev")|' \
      -i chrome/common/chrome_paths_linux.cc

  msg2 "Patching the sources"
  # Patch sources from Gentoo.
  patch -p1 -i "${srcdir}/chromium-system-ffmpeg-r4.patch"
  patch -p1 -i "${srcdir}/chromium-system-jinja-r14.patch"
  patch -p1 -i "${srcdir}/chromium-system-zlib-r1.patch"
  patch -p1 -i "${srcdir}/chromium-gn-r7.patch"

  # Misc Patches:
  if [ "${_patch_vaapi}" = "1" ]; then
    (cd "${srcdir}"; bsdtar -xf "chromium-browser_55.0.2868.3-0ubuntu1~ppa2~16.10.1.debian.tar.xz" debian/patches/enable_vaapi_on_linux.diff; mv debian/patches/enable_vaapi_on_linux.diff .; rm -fr debian)
    patch -p1 -i "${srcdir}/enable_vaapi_on_linux.diff"
  elif [ "${_patch_vaapi}" = "0" ]; then
    # Fix paths.
    sed -e 's|/usr/lib/|/usr/lib32/|g' \
        -e 's|/usr/lib64/|/usr/lib/|g' \
        -i content/common/sandbox_linux/bpf_gpu_policy_linux.cc
  fi
  patch -p1 -i "${srcdir}/minizip.patch"
  patch -p1 -i "${srcdir}/unset-madv_free.patch"

  # Patch from crbug (chromium bugtracker).
  # https://crbug.com/473866
  patch -p0 -i "${srcdir}/chromium-widevine-r1.patch"
  sed 's|@WIDEVINE_VERSION@|The Cake Is a Lie|g' -i "third_party/widevine/cdm/stub/widevine_cdm_version.h"

  ##
  # Fix libpng errors.
  msg2 "Attempt for fix libpng errors"
  for _path in 'chrome/app/theme' 'chrome/renderer' 'ui'; do
    pushd "${_path}" &> /dev/null
    export IFS=$'\n'
    for i in $(find . -name '*.png' -type f); do
      mogrify "${i}" &> /dev/null
    done
    export IFS=' '
    popd &> /dev/null
  done

  # Make it possible to remove third_party/adobe.
  echo > "${srcdir}/flapper_version.h"

  # Remove most bundled libraries. Some are still needed.
  msg2 "Removing unnecessary components to save space"
  python2 build/linux/unbundle/remove_bundled_libraries.py ${_keeplibs[@]} --do-remove
  rm -fr native_client/toolchain
  rm -fr build/linux/debian*

  msg2 "Make sure use Python2"
  find . -name '*.py' -exec sed -r 's|/usr/bin/python$|&2|g' -i {} +
  find . -name '*.py' -exec sed -r 's|/usr/bin/env python$|&2|g' -i {} +

  touch chrome/test/data/webui/i18n_process_css_test.html

  # Changing bundle libraries to system ones.
  python2 build/linux/unbundle/replace_gn_files.py --system-libraries ${_use_system[@]}

  # update libaddressinput strings.
  python2 third_party/libaddressinput/chromium/tools/update-strings.py

  # Use the file at run time instead of effectively compiling it in.
  sed 's|//third_party/usb_ids/usb.ids|/usr/share/hwdata/usb.ids|g' -i device/usb/BUILD.gn

  if [ "${_build_nacl}" = "1" ]; then
    msg2 "Setup NaCl/PNaCl SDK: Download and install NaCl/PNaCl toolchains"
    python2 build/download_nacl_toolchains.py --packages nacl_x86_newlib,pnacl_newlib,pnacl_translator sync --extract
    # Download clang from google. need for build NaCl. also is used by build the project in x86_64 systems when use clang
    python2 tools/clang/scripts/update.py
  fi

  # Setup compilers.
  # Use system/bundled Clang? or GCC?.
  if [ "${_use_clang}" = "0" ]; then
    _flags+=('is_clang=false'
             'clang_use_chrome_plugins=false'
             )
    export CC="${_ccache} gcc -Wall"
    export CXX="${_ccache} g++ -Wall"
  elif [ "${_use_clang}" = "1" ]; then
    if [ "${CARCH}" = 'i686' ]; then
      msg2 "Build with (bundled) clang is not possible in 32bit systems. then, Use system GCC"
      _flags+=('is_clang=false'
               'clang_use_chrome_plugins=false'
               )
      export CC="${_ccache} gcc -Wall"
      export CXX="${_ccache} g++ -Wall"
    elif [ "${CARCH}" = 'x86_64' ]; then
      msg2 "Setup for use clang"
      _flags+=('is_clang=true'
               'clang_use_chrome_plugins=true'
               )
      _clang_path="${srcdir}/chromium-${pkgver}/third_party/llvm-build/Release+Asserts/bin"
      export CXXFLAGS="${CXXFLAGS} -Wno-unknown-warning-option"
      export CC="${_ccache} ${_clang_path}/clang -Qunused-arguments"
      export CXX="${_ccache} ${_clang_path}/clang++ -Qunused-arguments"
    fi
  fi
}

build() {

  msg2 "Build the Launcher"
  make -C "chromium-launcher-${_launcher_ver}" CHROMIUM_SUFFIX="-dev" PREFIX=/usr ${_launcher_gtk}

  cd "chromium-${pkgver}"

  msg2 "Starting building Chromium..."
  # Configure the builder.
  python2 tools/gn/bootstrap/bootstrap.py -v --gn-gen-args "${_flags[*]} ${_debug_flag}"
  out/Release/gn gen out/Release -v --args="${_flags[*]} ${_debug_flag}" --script-executable=/usr/bin/python2

  # Build mksnapshot and pax-mark it.
  if [ "${_use_pax}" = "1" ]; then
    ninja -C out/Release -v mksnapshot
    paxctl -cm out/Release/mksnapshot
  fi

  # Build all with ninja.
  LC_ALL=C ninja -C out/Release -v pdf chrome chrome_sandbox chromedriver widevinecdmadapter clearkeycdm

  # Pax-mark again.
  if [ "${_use_pax}" = "1" ]; then
    paxctl -cm out/Release/chrome
  fi
}

package() {
  # Install launcher.
  make -C "chromium-launcher-${_launcher_ver}" CHROMIUM_SUFFIX="-dev" PREFIX=/usr DESTDIR="${pkgdir}" install-strip
  install -Dm644 "chromium-launcher-${_launcher_ver}/LICENSE" "${pkgdir}/usr/share/licenses/chromium-dev/LICENSE.launcher"

  pushd "chromium-${pkgver}/out/Release" &> /dev/null

  if [ "${_debug_mode}" = "1" ]; then
    # Build with debug needs a tons of space. remove this save that space, but break the rebuild process.
    rm -fr "chromium-launcher-${_launcher_ver}/third_party"
  fi

  # Install binaries.
  install -Dm755 chrome "${pkgdir}/usr/lib/chromium-dev/chromium-dev"
  install -Dm644 chrome.1 "${pkgdir}/usr/share/man/man1/chromium-dev.1"
  install -Dm4755 chrome_sandbox "${pkgdir}/usr/lib/chromium-dev/chrome-sandbox"
  install -Dm755 chromedriver "${pkgdir}/usr/lib/chromium-dev/chromedriver"
  ln -s /usr/lib/chromium-dev/chromedriver "${pkgdir}/usr/bin/chromedriver-dev"

  # Install libs.
  for i in libwidevinecdmadapter libclearkeycdm; do
    install -Dm755 "${i}.so" "${pkgdir}/usr/lib/chromium-dev/${i}.so"
  done
  install -Dm644 natives_blob.bin "${pkgdir}/usr/lib/chromium-dev/natives_blob.bin"
  install -Dm644 snapshot_blob.bin "${pkgdir}/usr/lib/chromium-dev/snapshot_blob.bin"

  _resources=('chrome_100_percent'
              'chrome_200_percent'
              'keyboard_resources'
              'mus_app_resources_100'
              'mus_app_resources_200'
              'mus_app_resources_strings'
              'resources'
              'views_mus_resources'
              )
  # Install Resources.
  for i in "${_resources[@]}"; do
    install -Dm644 "${i}.pak" "${pkgdir}/usr/lib/chromium-dev/${i}.pak"
  done

  # Install locales.
  find locales -type f -name "*.pak" -exec install -Dm644 '{}' "${pkgdir}/usr/lib/chromium-dev/{}" \;
  find resources -type f -name "*" -exec install -Dm644 '{}' "${pkgdir}/usr/lib/chromium-dev/{}" \;
  (cd "${pkgdir}/usr/lib/chromium-dev"; ln -s locales remote_locales)

  # Install icons.
  for _size in 16 22 24 32 48 128 256; do
    case "${_size}" in
      16|32) _branding="${srcdir}/chromium-${pkgver}/chrome/app/theme/default_100_percent/chromium" ;;
      *) _branding="${srcdir}/chromium-${pkgver}/chrome/app/theme/chromium" ;;
    esac
    install -Dm644 "${_branding}/product_logo_${_size}.png" "${pkgdir}/usr/share/icons/hicolor/${_size}x${_size}/apps/chromium-dev.png"
  done

  # Install NaCL stuff if is detected.
  if [ "${_build_nacl}" = "1" ]; then
    install -Dm755 nacl_helper "${pkgdir}/usr/lib/chromium-dev/nacl_helper"
    install -Dm755 nacl_helper_bootstrap "${pkgdir}/usr/lib/chromium-dev/nacl_helper_bootstrap"
    install -Dm755 nacl_helper_nonsfi "${pkgdir}/usr/lib/chromium-dev/nacl_helper_nonsfi"
    install -Dm755 "nacl_irt_x86_64.nexe" "${pkgdir}/usr/lib/chromium-dev/nacl_irt_x86_64.nexe"
    install -Dm644 icudtl.dat "${pkgdir}/usr/lib/chromium-dev/icudtl.dat"
  fi

  popd &> /dev/null

  # Install some external files.
  install -Dm644 "chromium-${pkgver}/chrome/installer/linux/common/desktop.template" "${pkgdir}/usr/share/applications/chromium-dev.desktop"
  sed -e 's|@@MENUNAME@@|Chromium-dev|g' \
      -e 's|@@USR_BIN_SYMLINK_NAME@@|chromium-dev|g' \
      -e 's|@@PACKAGE@@|chromium-dev|g' \
      -i "${pkgdir}/usr/share/applications/chromium-dev.desktop"
  install -Dm644 chromium-dev.svg "${pkgdir}/usr/share/icons/hicolor/scalable/apps/chromium-dev.svg"
  install -Dm644 "chromium-${pkgver}/LICENSE" "${pkgdir}/usr/share/licenses/chromium-dev/LICENSE"

  if [ "${_debug_mode}" = "0" ]; then
    # Manually strip binaries so that 'nacl_irt_*.nexe' is left intact.
    if [ "${_build_nacl}" = "1" ]; then
      strip $STRIP_BINARIES "${pkgdir}/usr/lib/chromium-dev/"nacl_helper{,_bootstrap,_nonsfi}
    fi
    strip $STRIP_BINARIES "${pkgdir}/usr/lib/chromium-dev/"{chromium-dev,chrome-sandbox,chromedriver}
    strip $STRIP_SHARED "${pkgdir}/usr/lib/chromium-dev/"lib{widevinecdmadapter,clearkeycdm}.so
  fi
}

fqj1994 commented 7 years ago

I'll try set it to 1 in evening (Central European Summer Time).

kj-sh604 commented 7 years ago

nice, it compiles on my system.. so i think enabling the vaapi patch won't cause it to not build anymore... Thanks =)) expecting to get chromium-dev with the vaapi patch from this repo again =))

fqj1994 commented 7 years ago

Returned home late. Probably I have to wait until Tuesday.

2016/10/02 午後11:56 "Aedriel Javier" notifications@github.com:

nice, it compiles on my system.. so i think enabling the vaapi patch won't cause it to not build anymore... Thanks =)) expecting to get chromium-dev with the vaapi patch from this repo again =))

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/archlinuxcn/repo/issues/283#issuecomment-250998951, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXq-ukFkr1-nisGhraQ-lf2gNQnrwO6ks5qwCingaJpZM4KLxqi .

axfelix commented 7 years ago

Thanks for providing the patch, this package has been a bit of a bear lately. Looking forward to seeing if the next build has fixed vaapi.

fqj1994 commented 7 years ago

I updated this manually, and it's building now. I'll upload it to archlinuxcn/ tomorrow (Europe Central Time) if the build succeded. And updated to code to replace _vaapi to 1 by default. but before aur fixes the problem the file name in noextract= (L115), the preprare (L397) function and the downloaded url (L90) are not consistent, the automatic build will fail for further updates.

sl1pkn07 commented 7 years ago

The problem is not about build or not build, the problem is, in my system, if I apply the pacth, i get segfault in the vaapi part and lost the HW acceleration (i'm nvidia user).

without patch, the HW acceleration working (again, for me) with zero issues.

for this, the apply or not the patch, need active by the user if set the variable _patch_vaapi (L17 as said @BigEars431) to 1

no need edit nothing about the patch. except when @saiarcot895 release the new version of their patch

fqj1994 commented 7 years ago

I don't have nvidia gpu to test this. I'll start to provide two binary builds to gain more feedback from the repo users since tomorrow. @sl1pkn07 can you update your PKGBUILD to make the file name in L90, L115, and L397 consistent? Or setting _patch_vaapi=1 will fail the makepkg due to file not found.

sl1pkn07 commented 7 years ago

done

axfelix commented 7 years ago

The new builds that were pushed today still aren't working for me to enable h264 again, but there's been some activity creating a new patch: https://github.com/saiarcot895/chromium-ubuntu-build/issues/2

fqj1994 commented 7 years ago

chromium-dev doesn't include the vaapi patch for now.

It looks either the build or the script failed for chromium-dev-vaapi

On Thu, Oct 6, 2016 at 1:15 AM, axfelix notifications@github.com wrote:

The new builds that were pushed today still aren't working for me to enable h264 again, but there's been some activity creating a new patch: saiarcot895/chromium-ubuntu-build#2 https://github.com/saiarcot895/chromium-ubuntu-build/issues/2

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/archlinuxcn/repo/issues/283#issuecomment-251826529, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXq-iftZXIfrpWBrVqthEQ-_qZRb27cks5qxC-KgaJpZM4KLxqi .

fqj1994 commented 7 years ago

I wrote something wrong for the sed syntax. Just fixed, hope it works. If yes, chromium-dev-vaapi will be pushed in less than 1 hour.

On Thu, Oct 6, 2016 at 1:25 AM, Qijiang Fan fqj1994@gmail.com wrote:

chromium-dev doesn't include the vaapi patch for now.

It looks either the build or the script failed for chromium-dev-vaapi

On Thu, Oct 6, 2016 at 1:15 AM, axfelix notifications@github.com wrote:

The new builds that were pushed today still aren't working for me to enable h264 again, but there's been some activity creating a new patch: saiarcot895/chromium-ubuntu-build#2 https://github.com/saiarcot895/chromium-ubuntu-build/issues/2

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/archlinuxcn/repo/issues/283#issuecomment-251826529, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXq-iftZXIfrpWBrVqthEQ-_qZRb27cks5qxC-KgaJpZM4KLxqi .

axfelix commented 7 years ago

Tested working on Intel!!

archlinuxcn / repo

Rebuild package chromium-dev with vaapi patch? if possible =)) (Included: a rough sample of a new PKGBUILD) #283