Hi, Thanks for your PR. Your commit has a few issues which would need to be solved for it to be accepted:
Your package does not build from a clean checkout (makepkg -C fails) because the Makefile does not re-include config.make after it has been written. You can put a yes "" | make config in prepare() to fix this (and use only make without yes in build()).
The patch command needs to be moved to prepare() to allow running build() with a modified src/ directory (currently makepkg ; makepkg -e fails).
Most of the other PKGBUILDs use patch -p1 -i ../file.patch (sometimes with -N) instead of patch < ../file.patch. I prefer to keep this syntax choice as much uniform as possible.
In short, I would prefer something like:
prepare() {
cd "${srcdir}/${pkgname/-selinux}"
sed -i "s#/sbin#/bin#" Makefile
sed -i "s#/usr##" man/Makefile
patch -p1 -i ../config.in.patch
yes "" | make config
}
build() {
cd "${srcdir}/${pkgname/-selinux}"
make
}
Moreover:
Please use the full pkgver of the base package (1.60.20130531git) instead of 1.60 so that tracking which version of net-tools official package is used is easier (with the compare_base.py script).
As this package creates a net-tools-selinux/net-tools directory which should not be included in the project, an entry in the main .gitignore file needs to be added.
Anyway, the functionalities of netstat are also provided by the ss command of iproute2 package, which is more maintained (I believe ss is to netstat what ip is to ifconfig but I'm not 100% sure about it). You might want to check it out depending on what you currently use netstat for.
Hi, Thanks for your PR. Your commit has a few issues which would need to be solved for it to be accepted:
makepkg -C
fails) because the Makefile does not re-includeconfig.make
after it has been written. You can put ayes "" | make config
inprepare()
to fix this (and use onlymake
withoutyes
inbuild()
).patch
command needs to be moved toprepare()
to allow runningbuild()
with a modifiedsrc/
directory (currentlymakepkg ; makepkg -e
fails).patch -p1 -i ../file.patch
(sometimes with-N
) instead ofpatch < ../file.patch
. I prefer to keep this syntax choice as much uniform as possible.In short, I would prefer something like:
Moreover:
1.60.20130531git
) instead of1.60
so that tracking which version ofnet-tools
official package is used is easier (with thecompare_base.py
script).net-tools-selinux/net-tools
directory which should not be included in the project, an entry in the main.gitignore
file needs to be added.Anyway, the functionalities of
netstat
are also provided by thess
command ofiproute2
package, which is more maintained (I believess
is tonetstat
whatip
is toifconfig
but I'm not 100% sure about it). You might want to check it out depending on what you currently usenetstat
for.