archlinuxhardened / selinux

PKGBUILDs to build SELinux enabled packages for Arch Linux
146 stars 25 forks source link

Add net-tools, for -Z support in netstat #1

Closed dasJ closed 9 years ago

fishilico commented 9 years ago

Hi, Thanks for your PR. Your commit has a few issues which would need to be solved for it to be accepted:

In short, I would prefer something like:

prepare() {
  cd "${srcdir}/${pkgname/-selinux}"
  sed -i "s#/sbin#/bin#" Makefile
  sed -i "s#/usr##" man/Makefile
  patch -p1 -i ../config.in.patch
  yes "" | make config
}

build() {
  cd "${srcdir}/${pkgname/-selinux}"
  make
}

Moreover:

Anyway, the functionalities of netstat are also provided by the ss command of iproute2 package, which is more maintained (I believe ss is to netstat what ip is to ifconfig but I'm not 100% sure about it). You might want to check it out depending on what you currently use netstat for.

dasJ commented 9 years ago

Thank you for reviewing. Because of ss, I will not fix this PR. If anybody is interested in netstat, they can fix this commit based on what you wrote.