archlinuxhardened / selinux

PKGBUILDs to build SELinux enabled packages for Arch Linux
146 stars 25 forks source link

Remove linux-selinux package and all references to it #53

Closed tqre closed 3 years ago

tqre commented 3 years ago

The package is deprecated, and doesn't exist in the official repositories any more.

I did a cleanup to the repo and scripts, but I'm not 100% sure if this package is still needed somewhere. If it is essential, this pull request can of course be trashed. Looking at discussion in Issue #19, it looks like it was about time...

Two mentions remain. I left these untouched as I'm not using Vagrant myself.

./_vagrant/step1_install_and_configure.sh:88:    # If using the deprecated linux-selinux kernel, replace the entries
./_vagrant/step1_install_and_configure.sh:89:    if grep 'LINUX \.\./vmlinuz-linux-selinux' /boot/syslinux/syslinux.cfg > /dev/null

The if clauses can probably be just dropped from the script for the looks of it.

fishilico commented 3 years ago

As it has been roughly 2 years since Arch Linux developers enabled SELinux support in package core/linux, linux-selinux is no longer needed and I agree removing it.

Two mentions remain. I left these untouched as I'm not using Vagrant myself.

With more context, _vagrant/step1_install_and_configure.sh contains:

if [ -e /boot/syslinux/syslinux.cfg ]
then
    if ! grep 'APPEND .*selinux=1 security=selinux' /boot/syslinux/syslinux.cfg > /dev/null
    then
        # Enable SELinux in kernel command line
        sed -i -e 's:\(^\s*APPEND \):\1selinux=1 security=selinux :' /boot/syslinux/syslinux.cfg
    fi
    # If using the deprecated linux-selinux kernel, replace the entries
    if grep 'LINUX \.\./vmlinuz-linux-selinux' /boot/syslinux/syslinux.cfg > /dev/null
    then
        sed -i -e 's:\(^\s*LINUX \.\./vmlinuz-linux\)-selinux$:\1:' /boot/syslinux/syslinux.cfg
        sed -i -e 's:\(^\s*INITRD \.\./initramfs-linux\)-selinux\(\(-fallback\)\?\.img\)$:\1\2:' /boot/syslinux/syslinux.cfg
    fi
fi

The last 2 sed lines are commands to replace vmlinuz-selinux with vmlinuz and initramfs-linux-selinux with initramfs-linux, in syslinux configuration which is used by the Vagrant virtual machine. This way, users who were using the Vagrant VM and who upgraded (with vagrant provision) at least once since these sed commands were introduced, now use the kernel from core/linux instead of linux-selinux. I will remove these lines, now that enough time has passed.