archlinuxhardened / selinux

PKGBUILDs to build SELinux enabled packages for Arch Linux
146 stars 25 forks source link

GitHub actions improved: releases works as a repo #79

Closed tqre closed 3 years ago

tqre commented 3 years ago

I worked some on our CI/CD pipeline:

Here is a resulting releases page from my fork, the pacman database files are new: https://github.com/tqre/selinux/releases/tag/ArchLinux-SELinux

And here is a link to artifacts (need to be signed in to GitHub to view): https://github.com/tqre/selinux/actions/runs/507124264

I tested to bootstrap a fresh Arch with SELinux support straight from above page, and it works like a charm.

Some todos as a reminder for the future:

tqre commented 3 years ago

Seems like this is a commonly occurring bug - Uploading artifacts fail. Reported this here: https://github.com/actions/upload-artifact/issues/154

On my branch everything worked out as it was supposed to...

fishilico commented 3 years ago

This looks great! And the repository works very nicely!

Two small comments when reading the changes:

Otherwise, this is really a great work, which is easy to understand and easy to use (thanks for the documentation in the README about the generated Arch Linux repository!)

tqre commented 3 years ago

Thanks for comments. I did the modifications you suggested:

Rename the VM files: archselinux.qcow2 is the base image which has SELinux support bootstrapped in. archselinux_test.qcow2 is the filename that has the test phase induced modifications recorded relative to the base image.

Removed the if clause from the prepare_release -step.

fishilico commented 3 years ago

Thanks! I rebased your commits on top of master and pushed them on https://github.com/archlinuxhardened/selinux/commits/315e0d4c4f5ba194540658c95fbca57ecc206686