archlinuxhardened / selinux

PKGBUILDs to build SELinux enabled packages for Arch Linux
146 stars 25 forks source link

Fix GitHub actions issues #84

Closed fishilico closed 3 years ago

fishilico commented 3 years ago

Here are some commits from https://github.com/archlinuxhardened/selinux/pull/83 and some modifications from me in order to :

This fixes https://github.com/archlinuxhardened/selinux/issues/81 and https://github.com/archlinuxhardened/selinux/issues/82.

tqre commented 3 years ago

Looks good to me, and certainly improving on the changes I made somewhat hastily just to get things working. I would actually keep the -v -tag on restorecon to see it work. Sure it generates a lots of logs, but I like logs :)

fishilico commented 3 years ago

I would actually keep the -v-tag on restorecon to see it work. Sure it generates a lots of logs, but I like logs :)

The thing is, generating many logs in GitHub Actions output is very impractical (the "find" function does not seem to work properly on the job output pages, and loading the whole page takes much time).

Nevertheless if you want logs, I would accept a patch which modifies the command in order to log the output of restorecon -RFv into a file and put this file into the build artifacts.