search

archonitelabs / radiant-cpp

Radiant Library (C++)
Apache License 2.0
2 stars 1 forks source link

Linter should fail workflow #20

Closed jxy-s closed 1 month ago

jxy-s commented 1 month ago

The linter will annotate a pull request but it will not fail the workflow for a PR, see:

https://github.com/archonitelabs/radiant-cpp/actions/runs/9451455938/job/26032442305?pr=19

I believe the following needs to return a non-zero return code to fail the workflow:

https://github.com/archonitelabs/radiant-cpp/blob/03c41a342a877b505d9862c31b262d09f036b6ea/tools/rad/rad/cli.py#L136-L149