search

archseer / colibri.vim

A subtle, elegant color scheme for vim.
https://archseer.github.io/colibri.vim/swatch.html
MIT License
92 stars 1 forks source link

MatchParen and Whitespace #4

Closed cideM closed 5 years ago

cideM commented 6 years ago

I had an issue with the existing MatchParen highlighting: my cursor would disappear on the first paren, and the eye would then immediately jump to the highlighted/matched paren. Right now the matched one is made bold whereas the first one is just untouched. If you don't like that, maybe a color could be chosen that are is background_light?

Additionally I linked Whitespace to SpecialKey. Without that, e.g., trailing spaces are almost invisible and when the cursor enters e.g., trailing spaces it too is pretty much gone.

archseer commented 6 years ago

Hi, thank you for your pull request! 🎊

What environment are you using, vim/nvim/gvim/oni? I'm using the terminal nvim, so I don't really see bold characters (maybe it's just my terminal, iTerm 2).

This is how parens get rendered for me:

screen shot 2018-04-26 at 22 25 01

The opening one ( is the one highlighted, and the orange one is the matching one. I do admit that I wasn't fully pleased with these two myself, since it's hard to tell which one is the cursor and which one is the matching one -- I tested a bunch of different versions but couldn't find a suitable one. I'll pull in your changes in the morning and give it a test!

Regarding the Whitespace group; in baseline vim, Whitespace doesn't exist and SpecialKey is used for both the special key highlights inside docs (like in :map, <space>, <C-s> etc). and for whitespace chars. I didn't quite like that so I appreciated the change in nvim where they split that so that the two can be styled separately.

For my use-case, I have a mapping for <leader>s that will toggle the whitespace character mode on/off, because I highlight all the spaces and line endings to be able to check indentation and trailing spaces, so I preferred the lighter styling.

screen shot 2018-04-26 at 22 30 37

Maybe I could make it a bit brighter though.

I think that for overriding this, just adding hi! link Whitespace SpecialKey to your vimrc is best.

cideM commented 6 years ago

This is what match paren looks like for me using Alacritty, Tmux, neovim on a Macbook. It looks like this outside of Tmux too. I can reproduce this on my linux machine running Arch, Alacritty and Tmux but just as well in Termite.

screen shot 2018-04-26 at 16 11 10

These are whitespace characters (there really are some, trust me :P)

screen shot 2018-04-26 at 16 12 22

And here the cursor is on those characters

screen shot 2018-04-26 at 16 12 26

Could that be related to set termguicolors or something? All of the above happen regardless of tmux/no tmux, alacritty/termite.

In iterm I don't get the paren issue as the cursor color is not dynamically adjusted it seems (regardless of smart cursor color).

archseer commented 5 years ago

Sorry for the long delay, so after switching to alacritty I was able to replicate the behavior: the cursor is set to inverse, then the vim color definition is also set to reverse, which causes this issue. I've fixed it in https://github.com/archseer/colibri.vim/commit/6d49c2bcb7b34d628b3214a62db1b8c57acb3a9d