archshift / Decrypt9

Multipurpose content dumper and decrypter for the Nintendo 3DS (SUPERSEDED)
GNU General Public License v2.0
103 stars 83 forks source link

Fixed screen output #23

Closed d0k3 closed 9 years ago

d0k3 commented 9 years ago

vasprintf() breaks the output for me (on Brahma).

Clearing the screen makes sense, because some ncchinfo.bin files completely fill the screen with Debug messages, leading to bad output otherwise.

d0k3 commented 9 years ago

... also, Ticket dumper now included.

archshift commented 9 years ago

I had already fixed the vasprintf issue on master, so that shouldn't be a problem anymore. Also, I'd appreciate it if you'd PR every new change/feature individually instead of congregating them all in one PR.

d0k3 commented 9 years ago

I see, you're currently working on getting the two branches into one (which is a great addition!), and your recent changes mean that this pull request is out of date. I'll do a separate PR for the ticket dumper and will limit my changes during the next few days only to source files that are identical to both branches. Plus, I will commit to master, because it looks like that will be the only branch left within a few days.

Update: done, you may close this PR now. The change in Debug() which clears the screen when the end is reached is still an important addition, because otherwise - for long outputs - new text will just overwrite old text, making for a badly readable result.