search

archshift / Decrypt9

Multipurpose content dumper and decrypter for the Nintendo 3DS (SUPERSEDED)
GNU General Public License v2.0
103 stars 83 forks source link

Various source code improvements and smaller fixes #28

Closed d0k3 closed 9 years ago

d0k3 commented 9 years ago

Detailed descriptions are included in the commit comments. The two smaller fixes from the fourth commit before are now included in commit #3, I hope that's okay. If anything should be organized differently - for this PR or for future PRs - just let me know.

Also sorry, about me breaking the last PR - don't know what happened there, but setting up a new one should be the correct choice.

d0k3 commented 9 years ago

The last commit removes the FileClose() from the DebugFileRead() / DebugFileWrite functions and moves it to where these are used. The two warnings in NcchPadgen should be redundant with DebugFileOpen() output, so these lines are removed for now. See above for mroe detailed descriptions.

archshift commented 9 years ago

Great! Just squash the last two commits together and I can merge this.

d0k3 commented 9 years ago

... and squashed into one commit. The next PRs will be more convenient to review and also actually add new features. I just have to do some more testing before.