search

archspec / archspec-json

Other
20 stars 33 forks source link

Added architecture flag znver3 for AOCC compiler 3.0 and above #25

Closed amd-toolchain-support closed 3 years ago

amd-toolchain-support commented 3 years ago

march and mtune flangs are added for znver3 when AOCC 3.0 or above compiler is used.

tgamblin commented 3 years ago

LGTM! Thanks! Any chance gcc and clang could also be added here?

GaneshPrasadMA commented 3 years ago

LGTM! Thanks! Any chance gcc and clang could also be added here?

Please note that we are supporting spack recipe for AOCC only

alalazo commented 3 years ago

@GaneshPrasadMA Thanks for the changes. I'll try to submit a draft PR in archspec based on this branch. If tests pass on that PR this would be fine with me. Otherwise I'll report the issues.

GaneshPrasadMA commented 3 years ago

Yes, please report issues if any so that we can try to fix them. I sincerely seek your guidance on the same as I am handling this magnitude of change in archspec for the first time.

GaneshPrasadMA commented 3 years ago

Thanks for pointing that out. It has been corrected and changes as per the review comment have been pushed.

alalazo commented 3 years ago

Thanks @GaneshPrasadMA !