archspec / archspec-json

Other
20 stars 33 forks source link

Removed 'erms' from microarchitectures.json for znver3 #27

Closed amd-toolchain-support closed 3 years ago

amd-toolchain-support commented 3 years ago

Removed 'erms' from microarchitectures.json for znver3

GaneshPrasadMA commented 3 years ago

After removal of "erms" in microarchitectures.json , znver3 detection was successful on following OS SLES 15,CentOS 8.2.2004 and CentOS 8.3.2011

alalazo commented 3 years ago

@amd-toolchain-support @GaneshPrasadMA I was wondering if the CPU flags invpcid, ospke and pku are relevant for binary compatibility between zen versions. I was briefly reading their description here:

invpcid: Invalidate Processor Context ID
pku: Protection Keys for Userspace
ospke: OS Protection Keys Enable

and they don't seem to be directly related to any instruction that can be emitted in the binary. Am I off track here?

GaneshPrasadMA commented 3 years ago

Please note that we will check the same and get back to you

GaneshPrasadMA commented 3 years ago

Removed entries invpcid,ospke, pku, in znver3 section and created a new pull request https://github.com/archspec/archspec-json/pull/28