search

archspec / archspec-json

Other
20 stars 33 forks source link

add support for nvhpc compilers to archspec #52

Closed cparrott73 closed 1 year ago

cparrott73 commented 2 years ago

Add support for flags used for nvhpc compilers to archspec-json.

cparrott73 commented 2 years ago

Ah yes, you are correct - due to the significant lag in getting approval to contribute here, it looks like my repo is out of date. I will respin my changes and resubmit. Sorry for the inconvenience.

cparrott73 commented 2 years ago

I've redone the changes and pushed out a new update to my branch. I checked with git diff, and it looks like these changes will not wipe out any recent updates. Could you give this another look when you have a chance? Thanks.

cparrott73 commented 2 years ago

I resynced my repo today with the new graviton3 section and amended it to include the nvhpc compilers. I think this should work now.

alalazo commented 2 years ago

@glennpj Would you mind giving this PR another look? If it is :heavy_check_mark: for you I'll try to integrate it with upstream archspec and add a couple of tests for it before merging.

tgamblin commented 1 year ago

@cparrott73: do you still want to get this one merged? It would be great to have better nvhpc support in archspec.

cparrott73 commented 1 year ago

Sorry, I missed seeing this somehow before now. What do you need of me here to continue to drive this process forward?

Thanks.

cparrott73 commented 1 year ago

I have created a new pull request, see: https://github.com/archspec/archspec-json/pull/66

Sorry for any inconvenience, I am a bit inexperienced when it comes to git and github. Thanks.