search

archspec / archspec-json

Other
20 stars 33 forks source link

Added Graviton3 as target architecture #53

Closed OliverPerks closed 2 years ago

OliverPerks commented 2 years ago

I think I have a 'good' set of architecture flags for the different compilers. Some may be missing, happy to iterate if we want to check any.

OliverPerks commented 2 years ago

Sorry, only just seen #51 - This one adds the 'correct' flags.

boegel commented 2 years ago

This looks way more mature than my PR #51, so I'll close that.

@alalazo Do we have a procedure in place to check/accept PRs like this?

OliverPerks commented 2 years ago

@alalazo - Sorry forgot to add that file. Done now.

OliverPerks commented 2 years ago

That is a good question. In theory Graviton X could have a feature Graviton X+1 doesn't support, but in practice they are strict subsets.

alalazo commented 2 years ago

In theory Graviton X could have a feature Graviton X+1 doesn't support, but in practice they are strict subsets.

If they are strict subsets I think we should reflect that. Can you add this last small change and change the "from" attributes of graviton3 and graviton2? The rationale is that we are focused on binary compatibility, so if we can always run a graviton binary on a graviton2 CPU having a linear inheritance among the labels makes more sense.

alalazo commented 2 years ago

Thanks @OliverPerks