search

archspec / archspec-json

Other
20 stars 33 forks source link

remove x86-64 from intel classic compiler #56

Closed simonLeary42 closed 1 year ago

simonLeary42 commented 1 year ago

x86-64 is nowhere in the intel classic compiler manual section on the march flag. 

/modules/spack-0.18.1/lib/spack/env/intel/icc -fPIC -O2 -D_LARGEFILE64_SOURCE=1  -c -o adler32.o adler32.c
icc: command line warning #10148: option '-march=x86-64' not supported

This should probably be fact checked on a system that isn't mine.

rscohn2 commented 1 year ago

I believe there was a slack discussion, but I don't know how to find it.

The problem I reported was that the oneapi compilers do not accept pentium4:

(venv) rscohn1@rscohn1-mobl1:compilers$ icpx -march=pentium4 ~/local/projects/spack/meson-project/cpp/main.cpp -c
error: unknown target CPU 'pentium4'
note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont,
      gracemont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell,
      common-avx512, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, rocketlake, icelake-server,
      tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3,
      amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3,
      x86-64-v4
(venv) rscohn1@rscohn1-mobl1:compilers$

The classic compilers accept pentium4, but not x86-64

rscohn2 commented 1 year ago

By the way, I just noticed that the latest classic compiler release has a deprecation message:

(venv) rscohn1@rscohn1-mobl1:compilers$ icc -march=x86-64 ~/local/projects/spack/meson-project/cpp/main.cpp -c
icc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second hal\
f of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this co\
mpiler. Use '-diag-disable=10441' to disable this message.

Is there something I should do to expose this to spack users?

alalazo commented 1 year ago

@simonleary-umass-edu Thanks a bunch for submitting the issue. Since it is a small bug fix I took the liberty of going ahead and pushing the fix we suggested above.