search

archspec / archspec-json

Other
20 stars 32 forks source link

neoverse-v1: fix flags for GCC #64

Closed bernhardkaindl closed 1 year ago

bernhardkaindl commented 1 year ago

@alalazo @annop-w

I checked @annop-w spack PR https://github.com/spack/spack/pull/36277 because he wrote he would have to get signoff from his manager to contribute to this repo, so I've checked his changes.

They are mostly correct except that -mcpu=neoverse-v1 was already added with gcc-10.3: https://gcc.gnu.org/onlinedocs/gcc-10.3.0/gcc/AArch64-Options.html#AArch64-Options

So the commit message is:

gcc-10.2 added -mcpu=zeus for neoverse-v1 platform and -mcpu=neoverse-v1 was added with gcc-9.4, gcc-10.3 and gcc-11.0.

Inspired by https://github.com/spack/spack/pull/36277 by Annop Wongwathanarat but updated because for the gcc-10 series, -mcpu=neoverse-v1 started to appear already with gcc-10.3.0:

https://gcc.gnu.org/onlinedocs/gcc-10.3.0/gcc/AArch64-Options.html#AArch64-Options

annop-w commented 1 year ago

@bernhardkaindl Thanks for submitting the patch. The internal process to get permission to contribute to new open source project takes time.

We actually do not need a separate entry for 10.3 because -mcpu=zeus is an alias for -mcpu=neoverse-v1. I've also just realised that I did not fix it for GCC 8. -mcpu=neoverse-v1 should also be available for GCC 8.5.

annop-w commented 1 year ago

@bernhardkaindl Yes, looks OK. Thanks for making this change.