search

archway-network / archway

Archway Network
https://archway.io
Other
74 stars 99 forks source link

Bug: proto-gen generated files belong to root instead of user #358

Open zanicar opened 1 year ago

zanicar commented 1 year ago

System Information Archway Version: latest Commit Hash: c9ef7ada0c06b062f1d73c783de450c114883a47 OS & Version: OS: Garuda Linux x86_64 Kernel: 6.3.1-zen1-1-zen

Expected behavior make proto-gen generated files should belong to (be owned by) the user from the actual user space, i.e. the same user that cloned the repository.

Actual behavior make proto-gen generated files are owned by root user; This is a consequence of how tendermintdev/sdk-proto-gen image and container environment is configured and run.

Steps to reproduce

  1. Clone the repository
  2. Run make proto-gen
  3. Run ls -lh x/{module}/types

Note the owner for *.pb.go files = root

mrshukla1805 commented 1 year ago

Hi is anyone working on this issue or is it open?

zanicar commented 1 year ago

We have an open PR for the issue: #371 but it needs further testing. Under Windows Subsystem for Linux it fails with "Illegal operation" related to differences between sh and bash. I suspect the addition of environment variables to the Docker command invalidates the default environment leading to sh-bash issue;

However, I am unable to replicate this as I am running pure Linux.

george-aj commented 1 year ago

This is a temporary fix as I've run into this issue, but when running make or proto-gen as sudo, I use chown -R user /dir/path to take back ownership.