archway-network / archway

Archway Network
https://archway.io
Other
73 stars 98 forks source link

feat: pass in all app keepers to the upgrade handler #456

Closed spoo-bar closed 12 months ago

spoo-bar commented 12 months ago

None of the app keepers were passed on to the upgrade handler pre v4.0.1. This hadn't been needed for any upgrades before. https://github.com/archway-network/archway/issues/438 required passing of account keeper to the upgrade handler as the fee_collector account permissions had to be modified as done so in https://github.com/archway-network/archway/pull/437

However, due to the urgency of the issue at the time, the hardcoded approach of just passing the account keeper was taken. Now, we need to refactor the upgrade handlers and app.go to allow a more robust way to pass down all the app keepers so modifications can be make during upgrade process.

This is specifically needed for the sdk v0.47 upgrade as the x/gov params need to be updated as well as the params subspace migrated