search

archway-network / archway

Archway Network
https://archway.io
Other
72 stars 99 forks source link

feat: Implement genesis methods #515

Closed spoo-bar closed 9 months ago

spoo-bar commented 9 months ago

Implementing

Removing the callbacks from the genesis state as it wouldnt make sense to import them on to new chain? where blockheight etc might be different.

Alternatively, we could export the who reserved the callback and how much they paid, and during import genesis, refund that amount. as callbacks are not imported during InitGenesis.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (feat/callback-module@8fcb507). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/callback-module #515 +/- ## ======================================================= Coverage ? 64.52% ======================================================= Files ? 69 Lines ? 4068 Branches ? 0 ======================================================= Hits ? 2625 Misses ? 1314 Partials ? 129 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aelesbao commented 9 months ago

Good catch. I also like the alternative idea. In which condition would that happen, though?

spoo-bar commented 9 months ago

Good catch. I also like the alternative idea. In which condition would that happen, though?

Community forks the chain maybe🤔