search

archway-network / archway

Archway Network
https://archway.io
Other
72 stars 99 forks source link

feat(cwgrants): Implement x/cwgrants module #527

Closed fdymylja closed 7 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 137 lines in your changes are missing coverage. Please review.

Comparison is base (58575f1) 65.61% compared to head (6c3505b) 64.50%.

Files Patch % Lines
x/cwfees/types/cw.go 0.00% 37 Missing :warning:
x/cwfees/keeper.go 68.05% 15 Missing and 8 partials :warning:
x/rewards/ante/fee_deduction.go 32.35% 22 Missing and 1 partial :warning:
x/cwfees/module.go 46.87% 16 Missing and 1 partial :warning:
x/cwfees/types/msgs.go 0.00% 16 Missing :warning:
x/cwfees/msg_server.go 7.69% 12 Missing :warning:
x/cwfees/query_server.go 12.50% 7 Missing :warning:
x/cwfees/types/codec.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #527 +/- ## ========================================== - Coverage 65.61% 64.50% -1.12% ========================================== Files 80 88 +8 Lines 4633 4851 +218 ========================================== + Hits 3040 3129 +89 - Misses 1436 1556 +120 - Partials 157 166 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fdymylja commented 7 months ago

@zanicar I would propose we keep as is, and consider renaming this cwfeegrants, to be in line with cosmos sdk's fee grant module, at nomenclature level, I will create an issue.