arckinteractive / elgg_hybridauth

HybridAuth Client for Elgg
10 stars 9 forks source link

Static file for credentials proposed feature - issue #34 #35

Open Facyla opened 7 years ago

Facyla commented 7 years ago

Hi,

Here's a proposed static config file feature proposition following https://github.com/arckinteractive/elgg_hybridauth/issues/34#issuecomment-344689121 : in this version, only the credentials (keys, ids, secrets) can be set and used :

=> I didn't found very useful to define the other plugin settings values, as they are non-sensitive data. But can do if it's worth it ?

I haven't changed the README file, but the settings_dist.php file is self-documented. An proposed doc section could be :

Static file configuration

To avoid disclosing providers keys, IDs and secrets to site admins, you can use a static configuration file. This file should be named settings.php and is ignored by git. The non-empty key/id/secret defined in this file will be used instead of plugin settings If set to FALSE, the plugin setting value (from admin panel) will be ignored, ie. this makes the corresponding provider unusable.