arckinteractive / elgg_solr

Basic solr integration to replace elgg search
GNU General Public License v2.0
7 stars 8 forks source link

Default $params['limit'] isn't set #17

Closed Daltonstudio closed 9 years ago

Daltonstudio commented 9 years ago

I experienced this long time ago and solved it by just providing a limit in my query, but now I looked at integrating solr again and noticed I have a lot of:

$options['query'] = 'testuser';
$results = elgg_trigger_plugin_hook('search', 'user', $options, array());

in my plugins (Ismayil's tokenize autocomplete plugin is an example) where no limit is given and this causes just an empty array, so no result Solrs default limit should be 10, but this seems not to be working.

What do you advice? I can replace

'rows'   => $params['limit'],

with

'rows'   => $params['limit'] ? $params['limit'] : '100',

in all the hooks, but I rather not do this if you consider this a bug.

beck24 commented 9 years ago

Fixed in version 1.9.1