search

arckinteractive / elgg_solr

Basic solr integration to replace elgg search
GNU General Public License v2.0
7 stars 8 forks source link

Does not work when installed with composer #20

Closed ewinslow closed 9 years ago

ewinslow commented 9 years ago

This line causes problems:

elgg_register_library('Solarium', dirname(__FILE__) . '/vendor/autoload.php');

Because /mod/elgg_solr/vendor/autoload.php doesn't exist if I just install this module with composer like so:

composer require arckinteractive/elgg_solr

My workaround was to include an empty vendor/autoload.php file in the repo, and then your packaging step I guess can bundle the dependencies if need be and overwrite the vendor/autoload.php file with a real one.

beck24 commented 9 years ago

oh, I see why that would be, that's annoying

I'm just going to commit the vendors with repo, I've started doing that with other repos anyway as it's been easier to manage in git for our projects

ewinslow commented 9 years ago

Sounds fine. Interested to see how things shake out with 2.0 supporting composer explicitly.

On Fri, Aug 7, 2015, 11:17 AM Matt Beckett notifications@github.com wrote:

oh, I see why that would be, that's annoying

I'm just going to commit the vendors with repo, I've started doing that with other repos anyway as it's been easier to manage in git for our projects

— Reply to this email directly or view it on GitHub https://github.com/arckinteractive/elgg_solr/issues/20#issuecomment-128786222 .

beck24 commented 9 years ago

Fixed in: https://github.com/arckinteractive/elgg_solr/commit/f8f2b41be611289740e6775236be58aef5762045