search

arckinteractive / elgg_solr

Basic solr integration to replace elgg search
GNU General Public License v2.0
7 stars 8 forks source link

Make default search case insensitive #23

Closed gerard-kanters closed 8 years ago

gerard-kanters commented 8 years ago

Using field type text_general instead of string makes it cases insensitive which is more user friendly

beck24 commented 8 years ago

why would the type need to be text_general? That's one of the most static things in the ElggEntity

beck24 commented 8 years ago

additional fields in any fieldtype can be assigned in the hooks

gerard-kanters commented 8 years ago

This PR was not about defining additional fields, but changing the schema.xml. As far as I can see the hooks are not meant for that.

beck24 commented 8 years ago

yeah but the PR changed one field - type - to text_general from string. What is a use case for searching the entity type case insensitive? There's only 3 options it can be anyway

gerard-kanters commented 8 years ago

I do not know now anymore. We had a customer having specific search requirements like case insensitive searching and this worked. I totally forgot to document why and how :-(