search

arckinteractive / elgg_solr

Basic solr integration to replace elgg search
GNU General Public License v2.0
7 stars 8 forks source link

Is friends access implemented correctly? #7

Closed mrclay closed 10 years ago

mrclay commented 10 years ago

Just reading through code (not tested) but I don't see how elgg_solr_get_access_query() possibly creates the query outlined in this comment: https://github.com/arckinteractive/elgg_solr/blob/master/lib/functions.php#L646

It looks like you intend to produce OR (access_id:<ACCESS_FRIENDS> AND owner_guid:(<FRIENDS>)) but it doesn't look like the code could produce that query (e.g. I don't see "owner_guid" anywhere).

beck24 commented 10 years ago

You're right... I refactored that and messed it up. Thanks for being another set of eyes on it!