search

arclanguage / anarki

Community-managed fork of the Arc dialect of Lisp; for commit privileges submit a pull request.
http://arclanguage.github.io
Other
1.17k stars 160 forks source link

html and css update #126

Closed kennethrapp closed 6 years ago

kennethrapp commented 6 years ago

This is a mostly finished (see below) update to the CSS and HTML to bring it up to more modern standards. It's also kind of huge so I'm definitely leaving it uncommitted in lieu of feedback.

Page macros have been consolidated so that all pages have the same layout - minipage and msgpage now call longpage, which now builds the entire HTML document. Inline CSS has been removed, but font color remains to be dealt with in a future update. The table layout has been removed and replaced with a basic layout of three divs (header, content and footer) and threads and lists now render in ordered or unordered lists. Render time should be faster now, although I haven't actually tested it.

I tried to keep the style as close as possible but some parts of the CSS may (probably do) need tweaking. The code for polls has been left more or less alone.

akkartik commented 6 years ago

Hmm, I just tried news.arc, and the assets aren't loading? Do I need to do any extra setup?

anarkinew

kennethrapp commented 6 years ago

No extra setup, it works for me. What does your browser console say, maybe there's a path issue?

The stylesheet has changed, make sure you're not caching the old one.

edit: I pushed an update for the paths in the template... maybe that fixes it?

hjek commented 6 years ago

Haven't tested this yet, but really like were this is going.

I found the tabular layout a bit illogical: It would be so convenient to represent a comment tree as, well, a tree of nested lists in the HTML. This is not just purely aesthetics, but anything involving styling or scripting, e.g. hiding comments, is just not straight-forward in the table layout. Thanks for taking a look at this, @kennethrapp.

For all the interesting ideas there are in Arc, using tables everywhere is really one of the worst; possibly apart from the unmarkdown function whose mere presence should be a cause of concern. I wish that the HN code was a bit more functional and used a bit less PLOP (PLace Oriented Programming) instead of forgetting original input and trying to recreate it again with unmarkdown.

Anyways, looking forward to try this out.

akkartik commented 6 years ago

Yeah, this is nice! It wasn't working for me because I was trying to load news.arc directly. Works after I actually, you know, follow the docs :)

There's some minor issues with margin/padding (see screenshot below). But we can polish further after merging this.

notables

kennethrapp commented 6 years ago

ok, nothing seems to be on fire so i'm merging