Define STRFTIME/MOMENT/MOMENT-MS/RSS-DATE

arclanguage / anarki

Community-managed fork of the Arc dialect of Lisp; for commit privileges submit a pull request.

http://arclanguage.github.io

Other

1.17k stars 160 forks source link

Define STRFTIME/MOMENT/MOMENT-MS/RSS-DATE #163

Open shawwn opened 5 years ago

shawwn commented 5 years ago

(Also define str and leftpad)

shawwn commented 5 years ago

I wanted to get another set of eyes on this before merging. strftime isn't meant to be a complete implementation, but it's pretty close.

akkartik commented 5 years ago

My eyes are not very useful when there aren't tests to run. But these are new functions so no worries. I assume you're running them in laarc? Please remember to backport bugfixes as you run into them.

Oh also, it may be convenient to add some examples just from things you try out at the repl. Easier than installing hg and unit-test.arc.

shawwn commented 5 years ago

I assume you're running them in laarc?

Yup! Previously I was shelling out to date using system, but that's very slow.

Please remember to backport bugfixes as you run into them.

No need to port bug fixes when the code is flawless. /s

(Good point! I'll be sure to port any fixes that come up.)

Oh also, it may be convenient to add some examples just from things you try out at the repl. Easier than installing hg and unit-test.arc.

Good idea!