search

arclanguage / anarki

Community-managed fork of the Arc dialect of Lisp; for commit privileges submit a pull request.
http://arclanguage.github.io
Other
1.17k stars 160 forks source link

resolve paths conflict when starting news, removed app editor #176

Closed kennethrapp closed 4 years ago

kennethrapp commented 4 years ago

I believe this should fix the issue with starting news from different paths... I haven't been able to replicate #175 but I'm leaving this unmerged in case someone else still can, merging tomorrow if it's OK.

Moving news back is still an option but it would take a bit of effort at this point.

There is one weird issue where a /www folder is created in the arc root whenever tests are run, I have no idea where that's coming from, though.

akkartik commented 4 years ago

I'll try it out in an hour or two.

akkartik commented 4 years ago

Looks good!

The www/ can be fixed by the following patch:

diff --git a/tests.arc b/tests.arc
index 0e37af7..012f06b 100644
--- a/tests.arc
+++ b/tests.arc
@@ -1,8 +1,5 @@
 (require 'lib/unit-test.arc/unit-test.arc)

-; ensure that all News libs are loaded
-(require 'apps/news/news.arc)
-
 ; tests currently rely on atstrings
 ; TODO: minimally turn on atstrings once unit-test.arc has support for suite
 ; setup/teardown functions

All tests continue to pass.

akkartik commented 4 years ago

Sorry, that isn't quite right. While my patch above is safe to delete, it doesn't fix the www/ problem.

The www/ problem is a side-effect of the run-request test suite.

Neither of these is related to this PR, so feel free to ignore them.