minor HTML updates - Githubissues

arclanguage / anarki

Community-managed fork of the Arc dialect of Lisp; for commit privileges submit a pull request.

http://arclanguage.github.io

Other

1.17k stars 160 forks source link

minor HTML updates #99

Closed kennethrapp closed 6 years ago

kennethrapp commented 6 years ago

Attempting to clean the app code up a bit:

added (then commented out) an HTML doctype. It broke the stylesheet, I don't know why.
moved css and js entirely to static files (hope this is OK)
added sctag macro for self closing html tags

akkartik commented 6 years ago

Thanks! This is a big PR; looks like you spent a lot of time on it. I'll try it out in a few hours.

kennethrapp commented 6 years ago

It's really not that big, I think I just broke it up into too many commits. I just wanted to see if I could fix some things that annoyed me about HN's layout, then I decided I should probably see if there's any interest upstream in updating the forum and app code, streamlining and simplifying it as much as possible.

If there is, I can keep pushing my fixes.

kennethrapp commented 6 years ago

Sorry... turns out (gentag) already generates standalone tags, so I removed my macro and used that. I need to read the docs more.

Last update to this pr unless there are more suggestions.

akkartik commented 6 years ago

No problem at all! I appreciate you going back to that macro.

akkartik commented 6 years ago

Great; merging.