search

arcnmx / wireplumber.rs

wireplumber rust bindings
https://arcnmx.github.io/wireplumber.rs/main/wireplumber/
MIT License
21 stars 3 forks source link

Make WpClient wrapper public #27

Closed tom-a-wagner closed 1 year ago

tom-a-wagner commented 1 year ago

The Client struct wasn't publicly visible before.

arcnmx commented 1 year ago

Merged as e3bf8642c71faa0e01117e182ba67fc397b20d05

(sorry that the ci is picky about formatting and linting, maybe I should relax parts of it...)

tom-a-wagner commented 1 year ago

@arcnmx Ci enforcing formatting is good IMO, pipewire-rs for example does the same.

Avoids unrelated changes in other commits whem code is formatted later.

I would've just force-pushed an update with fixed formatting, just didn't get around to it yet.

arcnmx commented 1 year ago

Formatting is fine to require yeah, and only a slight annoyance that's easy enough to catch/resolve. It's actually the commitlint rules that I feel might get in the way, and they're particularly pointless prior to an initial release since there won't be a changelog to produce!