Arguments checking bug

[4refr0nt]

If you pass retain = false when publish, then retain is true. Disabling retain flag only if retain option is undefined

                var options = {}
                options.topic = topic;
                options.payload = msg;
                options.qos = 0;
                options.retain = false;
                options.success = function() {};
                options.error = function() {};

                cordova.plugins.CordovaMqTTPlugin.publish(options)

[arcoirislabs]

We will fix the issue soon

[snr-lab]

So there are two bugs in cordova-plugin-mqtt.js file.

1. When you assign false to retain flag for publishing message it is always gets true. To fix this bug we need to update following line.

(args.retain===undefined) ? (args.retain=false) : (args.retain=true); To (args.retain===undefined) ? (args.retain=false) : "";

2. For will message configuration also retain flag always gets to true. To fix this bug we need to update following line.

args.willTopicConfig.retain||true To args.willTopicConfig.retain === undefined ? true : args.willTopicConfig.retain

This will not be affected for the value undefined as it already handled previously.

I have created a PR for this retain issue, please approve it.

[arcoirislabs]

@snr-lab Thank you for the PR. Just wanted to know that have you verified completely ??

[snr-lab]

Thank you very much for accepting my PR. I am developing an mqtt app and I am verifying the plugin repeatedly.

I got one bug with my fix when will message is not configured. I have fixed the issue and raised the PR. Please approve it.

[snr-lab]

Can we mark this bug resolved as the issue is fixed?

[arcoirislabs]

We need to see for any more errors. Till then let it be open

Sent from my iPhone

On 27-Jul-2017, at 10:32 AM, Rahul Kundu notifications@github.com wrote:

Can we mark this bug as resolved as the issue is fixed?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[snr-lab]

I found one more bug. When we set keep alive 0 it automatically get changed to 60000. According to the documentation 0 is also a valid input. It actually disables keep alive feature.

[spilz87]

Hello

It seems the issue is still there How to merge it in last release ?

[amaze-escape]

I can also confirm that the bug is still there...

[arcoirislabs]

Can you try this https://github.com/ameykshirsagar/cordova-plugin-mqtt