arcsidian / XivVoices

Turning Every Dialogue in Final Fantasy XIV Into a Voiced Dialogue!
https://arcsidian.com
MIT License
7 stars 0 forks source link

Player names and retainer names with special characters cause playback issues #2

Closed jordguitar closed 1 month ago

jordguitar commented 2 months ago

If a character name has a special character, or a retainer name has a special character, playback breaks depending on what you have enabled and disabled.

Example 1: Player name is O'raha Tia. If the dialogue has the first part of the player name in the dialogue box (O'raha), ALL audio for that dialogue box is not played (as long as it had a file to play in the first place). This is prevalent in MSQ dialogue.

Example 2: Retainer name is O'raha and Retainers playback is disabled in settings. The goodbye dialogue for the retainer is played when the retainer is dismissed. This does not affect retainers summoned after this.

arcsidian commented 2 months ago

Regarding Example 1: This error has been fixed in a previous version, I just tested it by speaking to "A'aba Tia" and his dialogue had "Amaj'aa" in it, it worked just fine in file, and even when I removed the file and enabled Local TTS, there were no issues. If it still persists for you, please include dalamud log for that conversation to see what's happening (C:\Users\USER\AppData\Roaming\XIVLauncher)

Regarding Example 2: This is most likely an error in the retainers json, that very sentence probably has a mismatch with the one in my list, I would like to know the race and gender if your retainer, so please talk to that retainer again and send me dalamug log,

jordguitar commented 2 months ago

Name still has issues, A' Test.:

2024-05-02 09:25:43.009 -05:00 [INF] [XivVoices] New Dialogue: [Gender]:Female, [Body]:1, [Race]:3, [Tribe]:6, [Eyes]:3 [Reported]:False [Ignored]:False, [Message]:A' Test. Well, ain't that a charmin' name. Just rolls off the tongue, it does.,
2024-05-02 09:25:43.009 -05:00 [INF] [XivVoices] PROCESS ---> Momodi: A' Test. Well, ain't that a charmin' name. Just rolls off the tongue, it does.
2024-05-02 09:25:43.009 -05:00 [INF] [XivVoices] GetNPC: Momodi - 1001353
2024-05-02 09:25:43.009 -05:00 [INF] [XivVoices] looking for path [G:/XIV_Voices\Data/Lalafell_Dunesfolk_Female_04/Momodi/atestwellaintthatacharminnamejustrollsoffthetongueitdoes.ogg]
2024-05-02 09:25:43.010 -05:00 [INF] [XivVoices] GetNPC: Momodi - 1001353
2024-05-02 09:25:43.010 -05:00 [INF] [XivVoices] looking for path [G:/XIV_Voices\Data/Lalafell_Dunesfolk_Female_04/Momodi/aadventurerwellaintthatacharminnamejustrollsoffthetongueitdoes.ogg]
2024-05-02 09:25:43.010 -05:00 [INF] [XivVoices] Reporting line: "A' Test. Well, ain't that a charmin' name. Just rolls off the tongue, it does."
2024-05-02 09:25:43.010 -05:00 [INF] [XivVoices] After processing: [Gender]:Female, [Body]:Adult, [Race]:Lalafell, [Tribe]:Dunesfolk, [Eyes]:Option 4 [Reported]:True [Ignored]:False, [Message]:A' Test. Well, ain't that a charmin' name. Just rolls off the tongue, it does.,
2024-05-02 09:25:43.010 -05:00 [INF] [XivVoices] AddToQueue ---> Momodi: A' Test. Well, ain't that a charmin' name. Just rolls off the tongue, it does.
2024-05-02 09:25:43.013 -05:00 [INF] [XivVoices] Update ---> Momodi: A' Test. Well, ain't that a charmin' name. Just rolls off the tongue, it does.
2024-05-02 09:25:43.013 -05:00 [WRN] Xiv Voices is accessing ObjectTable outside the main thread. This is deprecated.
2024-05-02 09:25:43.478 -05:00 [INF] [XivVoices] Report uploaded successfully.

a'testofyourplugin

Retainer is a Male Viera with the rough personality

2024-05-02 09:35:08.490 -05:00 [INF] [XivVoices] New Dialogue: [Gender]:Male, [Body]:1, [Race]:8, [Tribe]:15, [Eyes]:0 [Reported]:False [Ignored]:False, [Message]:About damn time! My ears were twitching summat fierce listening out for that bell...,
2024-05-02 09:35:08.490 -05:00 [INF] [XivVoices] PROCESS ---> A-bnuuy: About damn time! My ears were twitching summat fierce listening out for that bell...
2024-05-02 09:35:08.491 -05:00 [INF] [XivVoices] GetNPC: Viera Retainer M - 0
2024-05-02 09:35:08.491 -05:00 [INF] [XivVoices] looking for path [G:/XIV_Voices\Data/Viera_Veena_Male_03/Viera_Retainer_M/aboutdamntimemyearsweretwitchingsummatfiercelisteningoutforthatbell.ogg]
2024-05-02 09:35:10.876 -05:00 [INF] [XivVoices] New Dialogue: [Gender]:Male, [Body]:1, [Race]:8, [Tribe]:15, [Eyes]:0 [Reported]:False [Ignored]:False, [Message]:Right ye are, then!,
2024-05-02 09:35:10.876 -05:00 [INF] [XivVoices] PROCESS ---> A-bnuuy: Right ye are, then!
2024-05-02 09:35:10.877 -05:00 [INF] [XivVoices] GetNPC: Viera Retainer M - 0
2024-05-02 09:35:10.877 -05:00 [INF] [XivVoices] looking for path [G:/XIV_Voices\Data/Viera_Veena_Male_03/Viera_Retainer_M/rightyearethen.ogg]
2024-05-02 09:35:12.229 -05:00 [INF] [XivVoices] New Dialogue: [Gender]:Male, [Body]:1, [Race]:8, [Tribe]:15, [Eyes]:0 [Reported]:False [Ignored]:False, [Message]:Just say the word, yer lordship, and I'll be here with bells on.,
2024-05-02 09:35:12.229 -05:00 [INF] [XivVoices] PROCESS ---> A-bnuuy: Just say the word, yer lordship, and I'll be here with bells on.
2024-05-02 09:35:12.230 -05:00 [INF] [XivVoices] GetNPC: A-bnuuy - 0
2024-05-02 09:35:12.230 -05:00 [INF] [XivVoices] looking for path [G:/XIV_Voices\Data/Viera_Rava_Male_01/A_bnuuy/justsaythewordyerlordshipandillbeherewithbellson.ogg]
2024-05-02 09:35:12.247 -05:00 [INF] [XivVoices] After processing: [Gender]:Male, [Body]:Adult, [Race]:Viera, [Tribe]:Rava, [Eyes]:Option 1 [Reported]:False [Ignored]:False, [Message]:Just say the word, yer lordship, and I'll be here with bells on.,
2024-05-02 09:35:12.247 -05:00 [INF] [XivVoices] AddToQueue ---> A-bnuuy: Just say the word, yer lordship, and I'll be here with bells on.
2024-05-02 09:35:12.263 -05:00 [INF] [XivVoices] Update ---> A-bnuuy: Just say the word, yer lordship, and I'll be here with bells on.
2024-05-02 09:35:12.263 -05:00 [INF] [XivVoices] SpeakLocallyAsync ---> A-bnuuy: Just say the word, yer lordship, and I'll be here with bells on.
2024-05-02 09:35:12.263 -05:00 [INF] [XivVoices] SpeakLocallyAsync: found ogg path: G:/XIV_Voices\Data/Viera_Rava_Male_01/A_bnuuy/justsaythewordyerlordshipandillbeherewithbellson.ogg

a-testofyourbnuuy

arcsidian commented 2 months ago

Thank you for providing me with the logs, now I understand the issue more clearly, it's not the ' in the name, it's when the name ends with a ' without a follow-up letter, I just fixed it!

Also I added that mismatched sentence to the retainers list, so you won't face that problem anymore, I'll be pushing the update in a bit.