Fix for 2023.2 - Githubissues

arcsikex / cascadeur_bridge

This Blender addon is aimed to help you integrate Cascadeur into your workflow.

GNU General Public License v3.0

298 stars 13 forks source link

Fix for 2023.2 #37

Closed arcsikex closed 11 months ago

arcsikex commented 11 months ago

Change the parameter of calling commands from command line

jfaz1 commented 11 months ago

Thanks for keeping this updated! Trying the PR has a few issues for me:

When clicking on install requirements it fails, it seems to try finding a settings.ini but the latest Cascadeur version has a settings.json instead. You can probably fix this in csc_handling.py:

import json
...
    commands_config = os.path.join(resources_dir, "settings.json")
    with open(commands_config, "r") as f:
        data = json.load(f)
        scripts_dir = data.get("ScriptsDir", None)

When importing a sequence from cascadeur, it gets stuck with Operation in progress...

arcsikex commented 11 months ago

Thank you for testing the PR, I really appreciate it. I didn't have time to fully test out so your feedback helps a lot.

Not only the extension changed there but also the content of the file. Now it is possible to define multiple sources for the command files. I guess it's safe to remove this part completly.

jfaz1 commented 11 months ago

Thank you for testing the PR, I really appreciate it. I didn't have time to fully test out so your feedback helps a lot.

Not only the extension changed there but also the content of the file. Now it is possible to define multiple sources for the command files. I guess it's safe to remove this part completly.

All good, this tool has been essential to me so I'd like to help however I can, I just don't know much Python. I tried debugging why it gets stuck but couldn't figure it out :shrug: Sticking to 2023.1 for the time being, if you need help testing anything feel free to reach out.

arcsikex commented 11 months ago

@jfaz1 I pushed the removal of reading the settings.ini file if you want to give it a try.

jfaz1 commented 11 months ago

@jfaz1 I pushed the removal of reading the settings.ini file if you want to give it a try.

Yep it works, I still get the hanging issue though; does it work normally for you?

arcsikex commented 11 months ago

It's strange, I tried with complete reinstall and it works for me. Do you get any error message in Cascadeur?

arcsikex commented 11 months ago

@jfaz1 Please try to fully reinstall the addon. If the issue still persist create an issue on the issues page.

jfaz1 commented 11 months ago

@jfaz1 Please try to fully reinstall the addon. If the issue still persist create an issue on the issues page.

Not sure why but it works now, gonna open another unrelated issue, thanks!