Code Review - checklist

arctangent-nhsuk / the-way-we-work

0 stars 2 forks source link

Code Review - checklist #18

Closed arctangent closed 3 years ago

arctangent commented 3 years ago

In section 3.1.1:

ensure your team is following a code review checklist

Feedback:

do we have a code review checklist documented anywhere?

arctangent commented 3 years ago

Proposed action:

This is a question each Senior Developer should ask within their current delivery team
If they don't have one, then the team should agree one
SDMT may also wish to consider publishing a best practices guide

snehal-vahule commented 3 years ago

code review checklist should be on "Dot net standards" wiki https://dev.azure.com/nhsuk/dotnet-standards/_wiki/wikis/dotnet-standards/210/Home

sikanderakbarali commented 3 years ago

Is it it worth having a standard checklist that doesnt have to adhere to a certain tech stack? A checklist which is generic and works with any coding language

arctangent commented 3 years ago

Resolution:

No action for us here
Senior Devs can figure out how checklists would best work within and across the delivery teams