search

arctic-fire-development / dapper-gcs

node.js + HTML5 Ground Control Station for unmanned vehicles.
Other
9 stars 7 forks source link

removed reference to mavlink contained in etc/ and instead use npm to fetch it #661

Open h0st1le opened 9 years ago

h0st1le commented 9 years ago

I'm guessing the reason for the local mavlink_ardupilotmega_v1.0.tgz in etc/ was that it didn't exist on NPM when this project started? Regardless, the local package caused issues for me on Linux. Using the version from NPM fixed the problem.

brucecrevensten commented 9 years ago

Thanks for the pull request! You're right, there are some interdependencies between the javascript mavlink implementation and the code, I'd been waiting to push the npm changes until I had sorted a few things out, would you be willing to re-test against an updated npm mavlink prior to merging this?

On Mon, Oct 5, 2015 at 7:04 PM, Justin Penka notifications@github.com wrote:

I'm guessing the reason for the local mavlink_ardupilotmega_v1.0.tgz in etc/ was that it didn't exist on NPM when this project started? Regardless, the local package caused issues for me on Linux. Using the version from NPM

fixed the problem.

You can view, comment on, or merge this pull request online at:

https://github.com/arctic-fire-development/dapper-gcs/pull/661 Commit Summary

  • removed mavlink file reference and instead use npm to get version

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/arctic-fire-development/dapper-gcs/pull/661.

h0st1le commented 9 years ago

Sure, no problem at all. Just let me know when/what you want me to re-test. Cheers!

brucecrevensten commented 9 years ago

Thanks, I'll get at least a SITL-tested version up on npm this week, by Friday in my time zone. The changes are pretty slight but goofed up my local work quite a bit. Appreciated & I'll respond here with an update.

On Mon, Oct 5, 2015 at 7:26 PM, Justin Penka notifications@github.com wrote:

Sure, no problem at all. Just let me know when/what you want me to re-test. Cheers!

— Reply to this email directly or view it on GitHub https://github.com/arctic-fire-development/dapper-gcs/pull/661#issuecomment-145731685 .