search

arcturus / gulp-sww

Gulp plugin that creates all the support needed in serviceworkers to make your web app run offline
29 stars 3 forks source link

Accept several service worker files #16

Closed julienw closed 8 years ago

julienw commented 8 years ago

r? @arcturus

Would you please push a new version to npm if you merge ? :)

julienw commented 8 years ago

BTW I tried and debugged using a real project.

arcturus commented 8 years ago

Hi @julienw , I was thinking, can you achieve the same by including a single file that does the importScripts of different files, meaning, your injected file looks like:

importScripts(['/js/script1.js','/js/script2.js']);

I know we add a tiny bit of more latency, but want to check if i'm missing something of the concept.

julienw commented 8 years ago

I'm sure I can do this, but I thought it would be better in the tool. I'm also not so sure about the file manipulations to be honest. (I mean the array manipulations) But you're the master here :)

arcturus commented 8 years ago

Works for me on chrome and nightly, so far it works with the previous api and add some extra functionality so merging.