search

arcturus / gulp-sww

Gulp plugin that creates all the support needed in serviceworkers to make your web app run offline
29 stars 3 forks source link

Inline files to load. r=arcturus #8

Closed gmarty closed 8 years ago

gmarty commented 8 years ago

In this PR, the list of the files to cache by the service worker is inlined into the sw.js file. This reduces the risk of name collision and save a http request.

I also fixed the files list so that the ones needed by appCache only are not cached by the service worker and vice versa.

@arcturus: how does it look?

arcturus commented 8 years ago

r+ looks good to me, my only concern could be debugging the sw itself, but we will see. Saving a http request is also a good thing to take into account. Although IIRC, that file was cached too :D